-
Notifications
You must be signed in to change notification settings - Fork 0
Add AOT compatibility for net8.0 TFM #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BenjaminMichaelis
wants to merge
4
commits into
main
Choose a base branch
from
agents/aot-compliance-research-multitool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
79ddf5d
Add AOT compatibility for net8.0 TFM
BenjaminMichaelis 967084c
Add AOT publish test project and fix IsAotCompatible floor to net8.0
BenjaminMichaelis 878461a
Fix AOT test project issues from review
BenjaminMichaelis e1515e5
Guard ProjectPath with IsNullOrWhiteSpace instead of null check
BenjaminMichaelis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
IntelliTect.Multitool.AotTest/IntelliTect.Multitool.AotTest.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <IsPackable>false</IsPackable> | ||
| <PublishAot>true</PublishAot> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\IntelliTect.Multitool\IntelliTect.Multitool.csproj" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| using IntelliTect.Multitool; | ||
| using IntelliTect.Multitool.Extensions; | ||
|
|
||
| // StringExtensions | ||
| bool slugOk = "Hello, World!".CreateUrlSlug() == "hello-world"; | ||
| bool urlOk = "https://github.com/IntelliTect".ValidateUrlString(); | ||
|
|
||
| // SystemLinqExtensions | ||
| string?[] items = ["a", null, "b", null, "c"]; | ||
| bool filterOk = items.WhereNotNull().Count() == 3; | ||
|
|
||
| // ReleaseDateAttribute — returns null since no attribute on this assembly, | ||
| // but exercises the AOT-safe (statically-known type) GetCustomAttribute<T> code path | ||
| DateTime? releaseDate = ReleaseDateAttribute.GetReleaseDate(); | ||
| bool attributeOk = releaseDate is null; | ||
|
|
||
| if (!slugOk || !urlOk || !filterOk || !attributeOk) | ||
| { | ||
| Console.Error.WriteLine("AOT test FAILED."); | ||
| return 1; | ||
| } | ||
|
|
||
| // RepositoryPaths is excluded: its static initializer reads a build-time temp file | ||
| // that doesn't exist at AOT runtime. The class is AOT-compatible (file I/O + LINQ only). | ||
|
|
||
| Console.WriteLine("AOT test passed."); | ||
| return 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.