Skip to content

Update NumPy patching#170

Open
ndgrigorian wants to merge 6 commits intomainfrom
update-umath-patching
Open

Update NumPy patching#170
ndgrigorian wants to merge 6 commits intomainfrom
update-umath-patching

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Mar 10, 2026

This PR

  • Adds safety checks to patching
  • Add warnings related to multi-threaded programs
  • Implement _GlobalPatch wrapper class which implements patching globally
  • Rename _patch module to _patch_numpy
  • Rename patching functions
  • Aligns with mkl_fft and mkl_random patching interfaces

@ndgrigorian ndgrigorian force-pushed the update-umath-patching branch 4 times, most recently from c05279b to 1a4529a Compare March 10, 2026 04:19
@ndgrigorian ndgrigorian marked this pull request as ready for review March 10, 2026 04:33
@ndgrigorian
Copy link
Collaborator Author

ndgrigorian commented Mar 10, 2026

@antonwolfy @jharlow-intel
the patch update here is ready for review

@ndgrigorian ndgrigorian force-pushed the update-umath-patching branch from 1a4529a to e40ef5a Compare March 10, 2026 05:11
antonwolfy
antonwolfy reviewed Mar 10, 2026
View reviewed changes
antonwolfy
antonwolfy reviewed Mar 10, 2026
View reviewed changes
jharlow-intel
jharlow-intel reviewed Mar 10, 2026
View reviewed changes
antonwolfy
antonwolfy reviewed Mar 10, 2026
View reviewed changes
@ndgrigorian
Update umath patching
c07eef0 
* Add safety checks to patching
* Add warnings related to multi-threaded programs
* Implement _GlobalPatch wrapper class which implements patching globally
* Rename _patch module to _patch_numpy
* Rename patching functions
@ndgrigorian
address review comments
76c0e70
@ndgrigorian
add deprecated patching aliases to __init__.py
910011a
@ndgrigorian
pre-commit fix
711df0e
@ndgrigorian ndgrigorian force-pushed the update-umath-patching branch from a6a0c96 to 711df0e Compare March 10, 2026 16:15
@ndgrigorian
Copy link
Collaborator Author

ndgrigorian commented Mar 11, 2026

@jharlow-intel @antonwolfy
quick note, after adjusting the tests, I now see the segfault resolved in #171 locally

applying the fix did resolve it locally, as well

@ndgrigorian ndgrigorian force-pushed the update-umath-patching branch from 5ed8aee to 5cd2258 Compare March 11, 2026 23:44
@ndgrigorian ndgrigorian force-pushed the update-umath-patching branch from 11e83a8 to 7f0887f Compare March 11, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xaleryb xaleryb Awaiting requested review from xaleryb xaleryb is a code owner

@jharlow-intel jharlow-intel Awaiting requested review from jharlow-intel jharlow-intel is a code owner

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @antonwolfy @jharlow-intel