Fix TypeError with empty axes in FFT functions#288
Merged
antonwolfy merged 5 commits intomasterfrom Mar 13, 2026
Merged
Conversation
…dtype, not converting real to complex
jharlow-intel
approved these changes
Mar 12, 2026
Contributor
jharlow-intel
left a comment
There was a problem hiding this comment.
linux validation failure is due to bdba server outage, nothing to do with this PR.
LGTM, thanks for adding the new test cases, too
ndgrigorian
reviewed
Mar 12, 2026
ndgrigorian
approved these changes
Mar 12, 2026
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
other than previous comment LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes "copyto() argument 1 must be a numpy.ndarray" error, like:
when calling FFT functions with
axes=().Thus the PR adds a fast path to handle empty axes as identity transform, matching NumPy behavior.
The issue was introduced in scope of #283. The tests coverage is improved.