Fix building and running on pre-2026 MKL versions#193
Merged
ndgrigorian merged 8 commits intomasterfrom May 8, 2026
Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
ndgrigorian
force-pushed
the
fix-for-old-mkl-versions
branch
from
e957904 to
658f656
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to keep mkl-service building and testing cleanly across MKL versions around the 2026.0 API/constant churn (CNR branches + ISA constants), and adds a new macOS conda-forge workflow.
Changes:
- Add a version-compatibility shim in the Cython declarations to tolerate MKL constants being added/removed across releases.
- Update CNR/ISA handling and unit tests to version-gate legacy vs newly introduced branch/ISA names.
- Add a new GitHub Actions workflow to build/test conda-forge packages on macOS.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
mkl/tests/test_mkl_service.py |
Version-gates CBWR branch/ISA tests based on the runtime MKL major version. |
mkl/_mkl_service.pyx |
Conditionally exposes legacy CBWR branches/ISAs; updates CBWR auto-branch and instruction enable mappings. |
mkl/_mkl_service.pxd |
Adds a C preprocessor shim to define missing MKL constants to sentinel values for cross-version builds. |
conda-recipe/meta.yaml |
Adjusts mkl-devel host dependency selection for macOS builds. |
.github/workflows/conda-package-cf-osx.yml |
Introduces a macOS conda-forge build/test workflow. |
ndgrigorian
force-pushed
the
fix-for-old-mkl-versions
branch
3 times, most recently
from
f247abe to
b559fbd
Compare
allows mkl-service to work with both old and new versions
ndgrigorian
force-pushed
the
fix-for-old-mkl-versions
branch
2 times, most recently
from
5a48f02 to
b91187a
Compare
ndgrigorian
added a commit
that referenced
this pull request
May 8, 2026
Merged
antonwolfy
approved these changes
May 8, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
In general LGTM, the only small nits below:
ndgrigorian
added a commit
that referenced
this pull request
May 8, 2026
ndgrigorian
force-pushed
the
fix-for-old-mkl-versions
branch
from
2f3baeb to
44ef89d
Compare
also remove unnecessary cxx compiler settings
ndgrigorian
force-pushed
the
fix-for-old-mkl-versions
branch
from
44ef89d to
331d12f
Compare
antonwolfy
approved these changes
May 8, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian
ndgrigorian
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a compatibility shim for old MKL versions (prior to removal of some CNR branches and ISA constants).
Also adds a workflow for OSX