[MAINT] Change clang-format for pre-commit#161
Open
ndgrigorian wants to merge 3 commits intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s formatting/tooling setup to use mirrors-clang-format and a new .clang-format configuration, and removes the workflow’s manual installation of clang-format.
Changes:
- Switch pre-commit’s
clang-formathook topre-commit/mirrors-clang-formatatv22.1.0. - Add a repository
.clang-formatconfiguration file. - Remove the GitHub Actions step that installs and symlinks
clang-format-18.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
mkl/_mklinitmodule.c |
Pure reformatting consistent with clang-format settings (no functional diff apparent in the provided hunk). |
.pre-commit-config.yaml |
Points clang-format hook to mirrors-clang-format v22.1.0. |
.github/workflows/pre-commit.yml |
Removes OS-level clang-format installation, relying on pre-commit hook instead. |
.git-blame-ignore-revs |
Adds revision entry for the formatting-only change. |
.clang-format |
Introduces clang-format configuration used by the hook. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes