Skip to content

Deprecate dpnp.fix() #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vlad-perevezentsev merged 10 commits into from
Jan 22, 2026
Merged

Deprecate dpnp.fix() #2730

vlad-perevezentsev merged 10 commits into from
Jan 22, 2026

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Jan 20, 2026

This PR deprecates dpnp.fix() in favor of dpnp.trunc (following NumPy 2.5)

It adds DPNPDeprecatedUnaryFunc wrapper and updates tests to ignore DeprecationWarning

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jan 20, 2026
antonwolfy
antonwolfy reviewed Jan 20, 2026
View reviewed changes
antonwolfy
antonwolfy reviewed Jan 20, 2026
View reviewed changes
antonwolfy
antonwolfy reviewed Jan 20, 2026
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

View rendered docs @ https://intelpython.github.io/dpnp/pull/2730/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_67 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jan 20, 2026 •
edited
Loading

Coverage Status

coverage: 81.1% (+0.007%) from 81.093%
when pulling 7622709 on depr_fix
into 626bd3b on master.

antonwolfy
antonwolfy reviewed Jan 20, 2026
View reviewed changes
antonwolfy
antonwolfy approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev
LGTM with a small nit below

@vlad-perevezentsev @antonwolfy
apply a small nit
59acfe5 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@antonwolfy antonwolfy added this to the 0.20.0 release milestone Jan 21, 2026
@vlad-perevezentsev vlad-perevezentsev merged commit 865b53e into master Jan 22, 2026
68 of 94 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the depr_fix branch January 22, 2026 13:59
github-actions bot added a commit that referenced this pull request Jan 22, 2026
@github-actions
Deprecate dpnp.fix() (#2730)
ee39a11 
This PR deprecates `dpnp.fix()` in favor of `dpnp.trunc` (following
NumPy 2.5)
It adds `DPNPDeprecatedUnaryFunc` wrapper and updates tests to ignore
DeprecationWarning

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 865b53e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @coveralls @antonwolfy