Follow up the fix implemented in gh-2530 to fix dpnp.unique with axis=0 and 1d input#2587
Merged
antonwolfy merged 4 commits intomasterfrom Sep 23, 2025
Merged
Follow up the fix implemented in gh-2530 to fix dpnp.unique with axis=0 and 1d input#2587antonwolfy merged 4 commits intomasterfrom
dpnp.unique with axis=0 and 1d input#2587antonwolfy merged 4 commits intomasterfrom
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev4=py313h509198e_10 ran successfully. |
Collaborator
vlad-perevezentsev
approved these changes
Sep 23, 2025
Contributor
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR improves the fix implemented in
dpnp.uniquefor axis=0 and 1d input.Also it adds an explicit validation in case of floating axis passed.