Use oneMKL LAPACK gesv for dpnp.linalg.solve()#2558
Use oneMKL LAPACK gesv for dpnp.linalg.solve()#2558vlad-perevezentsev merged 8 commits intomasterfrom
gesv for dpnp.linalg.solve()#2558Conversation
e482aae to
3d737dc
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_26 ran successfully. |
|
Coverage decrease is expected. |
ndgrigorian
left a comment
There was a problem hiding this comment.
Seems to be having stability issues on Level Zero, internal CI shows it in TestSolve
@vlad-perevezentsev can you investigate if this is acceptable level of error and loosen the test if it is, and otherwise, look at it?
|
@ndgrigorian Thank you for noticing this! |
3367144 to
04afc1a
Compare
04afc1a
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Few minor nits below.
This PR suggests using oneMKL LAPACK
gesvinstead ofgetrfandgetrsindpnp.linalg.solve()since the issues in oneMKL have been resolved. This removes the workaround implemented in #1763