Implement `dpnp.erf` through pybind11 extension by antonwolfy · Pull Request #2551 · IntelPython/dpnp

antonwolfy · 2025-08-04T12:22:12Z

The PR changes the implementation of dpnp.erf function. It now invokes oneapi::mkl::vm implementation from pybind11 extension of OneMKL VM if possible or uses dedicated kernel from pybind11 extension of ufunc.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

github-actions · 2025-08-04T12:53:41Z

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_68 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

github-actions · 2025-08-04T12:54:28Z

View rendered docs @ https://intelpython.github.io/dpnp/index.html

coveralls · 2025-08-05T09:46:34Z

coverage: 71.755% (+0.1%) from 71.64%
when pulling 2de4f06 on add-erf-impl
into 25b7466 on master.

dpnp/backend/extensions/vm/erf.cpp

dpnp/special/_erf.py

vlad-perevezentsev

LGTM!
Thank you @antonwolfy for the implementation of dpnp.erf and significant cleanup of cython code!!!

… result, mismatching scipy

…th, and cron tests run Applly pre-commit rule in toml file

Applly pre-commit rule in toml file

…to pass dpnp with scipy>=1.16

Add a comment to casting in ErfFunctor implementation

antonwolfy · 2025-09-16T17:09:23Z

@ndgrigorian, let me know if you have more comments

ndgrigorian · 2025-09-16T18:26:53Z

dpnp/backend/kernels/elementwise_functions/erf.hpp

+namespace dpnp::kernels::erf
+{
+template <typename argT, typename Tp>
+struct ErfFunctor


to this day, I'm not sure why we didn't use inheritance with these structs from a common parent with sensible defaults. That may be the smart thing to do someday. For sure not in this PR though. Leaving this comment to remember.

ndgrigorian · 2025-09-16T18:30:35Z

dpnp/tests/test_special.py

+        result = dpnp.special.erf(ia)
+        expected = scipy.special.erf(a)


it might be more readable and reliable to simply test against the expected values, i.e, that erf(nan) gives nan, erf(inf) gives 1, and erf(-inf) gives -1

this way bugs or changes in behavior in scipy don't impact this test

also wouldn't mind tests for 0 and -0

It's the current dpnp approach to test against numpy or scipy to ensure alignment in the behavior.
Btw, I've added a dedicated test for signed zero.

ndgrigorian

other than minor comments about the test this LGTM

antonwolfy added this to the 0.19.0 release milestone Aug 4, 2025

antonwolfy self-assigned this Aug 4, 2025

antonwolfy force-pushed the add-erf-impl branch from c261a83 to 410dcb5 Compare September 3, 2025 17:26

antonwolfy marked this pull request as ready for review September 3, 2025 21:49

antonwolfy requested review from AlexanderKalistratov, ndgrigorian, vlad-perevezentsev and vtavana as code owners September 3, 2025 21:49

ndgrigorian reviewed Sep 11, 2025

View reviewed changes

dpnp/backend/extensions/vm/erf.cpp Show resolved Hide resolved

ndgrigorian reviewed Sep 11, 2025

View reviewed changes

dpnp/special/_erf.py Outdated Show resolved Hide resolved

vlad-perevezentsev approved these changes Sep 16, 2025

View reviewed changes

antonwolfy force-pushed the add-erf-impl branch from a801c13 to 78640ba Compare September 16, 2025 12:35

antonwolfy added 15 commits September 16, 2025 14:46

Add erf functor

7fdb022

Add erf implementation to ufunc extension

7f70f8f

Add dpnp.special submodule

5a376fd

Remove erf implementation from the legacy backend

4965194

Clean up backend utils

3bb62dd

Remove erf implementation from cython backend

92d3179

Clean up algo namespace in cython backend

388e213

Exclude the removed files from the cmake build

fe6cdd2

Clean up algo utils in cython backend

cbe3d3b

Add missing include to backend utils

6a74703

Add missing imports to algo namespace in cython backend

0f59c76

Remove obsolete libmath i/f

1e5225a

Implement erf function as ufunc extension

37b1afb

Reuse VM implementation of erf from oneMKL

f95f980

Enable VM implementation of erf from oneMKL

6c9a56f

antonwolfy added 22 commits September 16, 2025 14:46

Remove the dedicated erf kernel for half dtype due to accuracy of the…

5475810

… result, mismatching scipy

Add scipy as a test dependency

c49e627

Add third party tests for erf function

f7c5987

Add PR to the changelog

fb15bad

Add testing for more use cases

8795572

Add CFD tests

970ab3c

Add test with strides

d23b1f5

Enable erf tests for NVIDIA GPU

fdff2a4

Update rendered page for special submodule

af70928

Enable pylint for dpnp.special submodule

c4200c7

Mute false-positive pylint warnings

1f5c066

Add special dtype check in tests for scipy>=0.16

4ba8a38

Add third party tests for scipy into the package

2c2bb3d

Skip erf tests when no scipy installed

a45e6c5

Add missing includes

e853d13

Update docstring of erf function per review comment

6449839

Add optional test dependency to wheel package

b692646

Add running erf tests in worflows in public CI: coverage, check oneMa…

9cf614c

…th, and cron tests run Applly pre-commit rule in toml file

Rename environments/test_env.yml to environments/test.yml

fcc734c

Applly pre-commit rule in toml file

Fix a typo in changelog

f249639

Update tests/third_party/cupyx/scipy_tests/special_tests/test_erf.py …

a860f6a

…to pass dpnp with scipy>=1.16

Add a dedicated kernel for sycl::half input dtype

2de4f06

Add a comment to casting in ErfFunctor implementation

antonwolfy force-pushed the add-erf-impl branch from cd3c5d5 to 2de4f06 Compare September 16, 2025 12:46

ndgrigorian reviewed Sep 16, 2025

View reviewed changes

ndgrigorian approved these changes Sep 16, 2025

View reviewed changes

Add a dedicated test for zeros

be5e536

antonwolfy merged commit d289709 into master Sep 17, 2025
73 of 75 checks passed

antonwolfy deleted the add-erf-impl branch September 17, 2025 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `dpnp.erf` through pybind11 extension#2551

Implement `dpnp.erf` through pybind11 extension#2551
antonwolfy merged 38 commits intomasterfrom
add-erf-impl

antonwolfy commented Aug 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

coveralls commented Aug 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

vlad-perevezentsev left a comment

Uh oh!

antonwolfy commented Sep 16, 2025

Uh oh!

ndgrigorian Sep 16, 2025

Uh oh!

ndgrigorian Sep 16, 2025

Uh oh!

ndgrigorian Sep 16, 2025

Uh oh!

antonwolfy Sep 17, 2025

Uh oh!

ndgrigorian left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		result = dpnp.special.erf(ia)
		expected = scipy.special.erf(a)

Conversation

antonwolfy commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlad-perevezentsev left a comment

Choose a reason for hiding this comment

Uh oh!

antonwolfy commented Sep 16, 2025

Uh oh!

ndgrigorian Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

ndgrigorian Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

ndgrigorian Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

antonwolfy Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

ndgrigorian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

antonwolfy commented Aug 4, 2025 •

edited

Loading

github-actions bot commented Aug 4, 2025 •

edited

Loading

github-actions bot commented Aug 4, 2025 •

edited

Loading

coveralls commented Aug 5, 2025 •

edited

Loading