Skip to content

Use dpctl tensor include to use experimental SYCL namespace for complex types#2546

Merged
antonwolfy merged 2 commits intomasterfrom
use-dpctl-tensor-include
Jul 31, 2025
Merged

Use dpctl tensor include to use experimental SYCL namespace for complex types#2546
antonwolfy merged 2 commits intomasterfrom
use-dpctl-tensor-include

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 30, 2025 •
edited
Loading

The PR proposes to reuse dpctl, since it exposes sycl_complex.hpp header which enables experimental SYCL namespace for complex types.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 30, 2025
@antonwolfy antonwolfy self-assigned this Jul 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy mentioned this pull request Jul 30, 2025
Merged
7 tasks
@coveralls
Copy link
Collaborator

coveralls commented Jul 30, 2025

Coverage Status

coverage: 72.108%. remained the same
when pulling 9219370 on use-dpctl-tensor-include
into 4240292 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_28 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 30918e4 into master Jul 31, 2025
94 of 97 checks passed
@antonwolfy antonwolfy deleted the use-dpctl-tensor-include branch July 31, 2025 10:32
github-actions bot added a commit that referenced this pull request Jul 31, 2025
@github-actions
Use dpctl tensor include to use experimental SYCL namespace for compl…
a7a3838 
…ex types (#2546)

The PR proposes to reuse dpctl, since it exposes `sycl_complex.hpp`
header which enables experimental SYCL namespace for complex types. 30918e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev