Correct dependency on numpy version in test_1d_equal_nan_axis0#2538
Merged
antonwolfy merged 1 commit intomasterfrom Jul 25, 2025
Merged
Correct dependency on numpy version in test_1d_equal_nan_axis0#2538antonwolfy merged 1 commit intomasterfrom
test_1d_equal_nan_axis0#2538antonwolfy merged 1 commit intomasterfrom
Conversation
antonwolfy
requested review from
AlexanderKalistratov,
ndgrigorian,
vlad-perevezentsev and
vtavana
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_20 ran successfully. |
vlad-perevezentsev
approved these changes
Jul 25, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Thank you @antonwolfy . LGTM
github-actions bot
added a commit
that referenced
this pull request
Jul 25, 2025
The `test_1d_equal_nan_axis0` test depends on a fix for numpy#29372. It was not included as part of numpy 2.3.2 release. The PR proposes to updated the expected dependency on numpy version with the fix. add573a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_1d_equal_nan_axis0test depends on a fix for numpy#29372. It was not included as part of numpy 2.3.2 release.The PR proposes to updated the expected dependency on numpy version with the fix.