reverse the order of individual FFTs in rfftn#2524
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_11 ran successfully. |
Collaborator
vtavana
requested review from
AlexanderKalistratov,
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
github-actions bot
added a commit
that referenced
this pull request
Jul 13, 2025
For `numpy.fft.fftn` and `numpy.fft.ifftn`, individual FFTs over `axes` are performed in [reverse order](https://github.com/numpy/numpy/blob/v2.2.0/numpy/fft/_pocketfft.py#L739). Similarly, for `numpy.fft.rfftn`, individual FFTs are performed in [reverse order](https://github.com/numpy/numpy/blob/v2.2.0/numpy/fft/_pocketfft.py#L1382). However, for `numpy.fft.irfftn` individual FFTs are performed in [forward order](https://github.com/numpy/numpy/blob/v2.2.0/numpy/fft/_pocketfft.py#L1600). d5f67fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
numpy.fft.fftnandnumpy.fft.ifftn, individual FFTs overaxesare performed in reverse order.Similarly, for
numpy.fft.rfftn, individual FFTs are performed in reverse order.However, for
numpy.fft.irfftnindividual FFTs are performed in forward order.dpnp.fft.irfftnis updated to behave similar tonumpy.fft.irfftn.Note that the order is only important when there is repeated indices in
axesandsis notNone.