Avoid negating unsigned integers in dpnp.resize#2508
Merged
antonwolfy merged 4 commits intomasterfrom Jun 30, 2025
Merged
Conversation
antonwolfy
requested review from
AlexanderKalistratov,
ndgrigorian,
vlad-perevezentsev and
vtavana
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_33 ran successfully. |
Collaborator
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jun 30, 2025
This PR resolves an issue when calling `dpnp.resize` with unsigned integer size. The negation of an unsigned int underflows and creates a large positive repeats, which leads to a runtime error. The PR fixes the used ceil division. e3a9b5e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue when calling
dpnp.resizewith unsigned integer size.The negation of an unsigned int underflows and creates a large positive repeats, which leads to a runtime error. The PR fixes the used ceil division.