Validate HIP_TARGETS format and allow negative values#2481
Merged
vlad-perevezentsev merged 4 commits intomasterfrom Jun 16, 2025
Merged
Validate HIP_TARGETS format and allow negative values#2481vlad-perevezentsev merged 4 commits intomasterfrom
HIP_TARGETS format and allow negative values#2481vlad-perevezentsev merged 4 commits intomasterfrom
Conversation
vlad-perevezentsev
requested review from
AlexanderKalistratov,
antonwolfy,
ndgrigorian and
vtavana
as code owners
antonwolfy
reviewed
Jun 16, 2025
antonwolfy
reviewed
Jun 16, 2025
vlad-perevezentsev
force-pushed
the
update_amd_target_handling
branch
from
2303820 to
3609217
Compare
antonwolfy
approved these changes
Jun 16, 2025
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_16 ran successfully. |
Collaborator
github-actions bot
added a commit
that referenced
this pull request
Jun 16, 2025
This PR suggests validating the format of `HIP_TARGETS` (set via `--target-hip`) to ensure it starts with `gfx` (e.g., `gfx1030`). It also allows users to explicitly indicate that no AMD target should be used by passing values like `--target-hip=OFF` or `--target-hip=FALSE` matching the default behavior b10bd15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests validating the format of
HIP_TARGETS(set via--target-hip) to ensure it starts withgfx(e.g.,gfx1030).It also allows users to explicitly indicate that no AMD target should be used by passing values like
--target-hip=OFFor--target-hip=FALSEmatching the default behavior