Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_13 ran successfully. |
vtavana
force-pushed
the
fix-numpy-2.3
branch
4 times, most recently
from
96cf11b to
2320a26
Compare
vtavana
requested review from
AlexanderKalistratov,
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
antonwolfy
approved these changes
Jun 11, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
I left few minor comments, but in overall LGTM
Thank you @vtavana for adopting dpnp with numpy 2.3 and reporting identified issues.
added 2 commits
June 11, 2025 15:04
antonwolfy
approved these changes
Jun 14, 2025
github-actions bot
added a commit
that referenced
this pull request
Jun 14, 2025
Tests are updated to have a green CI with numpy-2.3.0. 1) `matmul` failure is because a [bug in NumPy](numpy/numpy#29164). 2) `numpy.unique` is modified in numpy-2.3, [dpnp should align](#2476) with recent changes. 3) There was a bug for calculating norm of empty arrays when `keepdims=True` is passed which is fixed. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to an issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] Have you added documentation for your changes, if necessary? - [x] Have you added your changes to the changelog? 4046985
antonwolfy
pushed a commit
that referenced
this pull request
Jun 20, 2025
Tests are updated to have a green CI with numpy-2.3.0. 1) `matmul` failure is because a [bug in NumPy](numpy/numpy#29164). 2) `numpy.unique` is modified in numpy-2.3, [dpnp should align](#2476) with recent changes. 3) There was a bug for calculating norm of empty arrays when `keepdims=True` is passed which is fixed. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to an issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] Have you added documentation for your changes, if necessary? - [x] Have you added your changes to the changelog?
antonwolfy
added a commit
that referenced
this pull request
Jun 20, 2025
7 tasks
antonwolfy
added a commit
that referenced
this pull request
Jun 23, 2025
The new numpy release `2.3.1` has been published which includes the fix for numpy#29164. That PR enables the previously muted tests for numpy 2.3.1 in #2477.
antonwolfy
added a commit
that referenced
this pull request
Jun 23, 2025
The new numpy release `2.3.1` has been published which includes the fix for numpy#29164. That PR enables the previously muted tests for numpy 2.3.1 in #2477.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are updated to have a green CI with numpy-2.3.0.
matmulfailure is because a bug in NumPy.numpy.uniqueis modified in numpy-2.3, dpnp should align with recent changes.keepdims=Trueis passed which is fixed.