Skip test_digitize_empty on LNL Windows#2407
Closed
vlad-perevezentsev wants to merge 1 commit intomasterfrom
Closed
Skip test_digitize_empty on LNL Windows#2407vlad-perevezentsev wants to merge 1 commit intomasterfrom
vlad-perevezentsev wants to merge 1 commit intomasterfrom
Conversation
vlad-perevezentsev
requested review from
AlexanderKalistratov,
antonwolfy,
ndgrigorian and
vtavana
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Apr 3, 2025
Comment on lines
+109
to
+114
| device_mask = ( | ||
| du.intel_device_info(x_dp.sycl_device).get("device_id", 0) | ||
| & 0xFF00 | ||
| ) | ||
| # upper byte of device_id for LNL architecture | ||
| if device_mask in [0x6400]: |
Contributor
There was a problem hiding this comment.
It'd be good to have a helper function which obtains a mask for the default or input device and checks if it matches with specified device architecture.
While for LNL arch value it'd be better to expose it as a enum value.
Contributor
There was a problem hiding this comment.
Meanwhile it might be helpful to add a link to the enum description on GitHub page where to find the values of device architectures.
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_66 ran successfully. |
Contributor
|
@vlad-perevezentsev, it seems it's not required anymore. Feel free to close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests skipping
test_digitize_empty - empty array caseon LunarLake Windows as a temporary workaround to avoid crashes in the internal CI