Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_55 ran successfully. |
vtavana
force-pushed
the
update_norm_FFT
branch
2 times, most recently
from
a4a76ca to
d719b0a
Compare
vtavana
force-pushed
the
update_norm_FFT
branch
from
d719b0a to
d3e8aa3
Compare
vtavana
requested review from
AlexanderKalistratov,
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
antonwolfy
approved these changes
Mar 27, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vtavana for the improvement.
In overall LGTM, just few minor nits for new test.
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
antonwolfy
approved these changes
Mar 28, 2025
github-actions bot
added a commit
that referenced
this pull request
Mar 28, 2025
In this PR, a utility function in FFT module is updated to remove duplication. In addition a new test is added to make coverage for FFT module 100%. 05b820d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, a utility function in FFT module is updated to remove duplication.
In addition a new test is added to make coverage for FFT module 100%.