Enable clip test from array-api-tests scope#2386
Conversation
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_6 ran successfully. |
|
The issue is still present and caused by dpctl-1742: File "/home/runner/miniconda3/envs/array-api-conformity/lib/python3.12/site-packages/dpctl/tensor/_clip.py", line 463, in clip
raise ValueError(
ValueError: function '<function clip at 0x7f52e1a619e0>' does not support input types (uint8, uint8, uint16), and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''.
Falsifying example: test_clip(
x=array(0, dtype=uint8),
data=data(...),
... |
I still think this may be a mistake in the array API tests Per spec, Also, |
|
Regardless of our intended solution, we can file this with the array API tests as an incorrectly designed test. It may have been more convenient to just enable type promotion in |
|
Issue open with array API |
|
PR is open that will resolve the issue in array API tests |
There were few fixes implemented in `array-api-tests` around clip tests. The PR proposes to enable `test_clip` test from `array-api-tests` scope. 2966ae6
There were few fixes implemented in
array-api-testsaround clip tests.The PR proposes to enable
test_cliptest fromarray-api-testsscope.