Explicit shape comparison for dpnp and numpy outputs#2295
Merged
antonwolfy merged 8 commits intomasterfrom May 15, 2025
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_24 ran successfully. |
Collaborator
vtavana
changed the title
dpnp and numpy outputs
vtavana
requested review from
AlexanderKalistratov,
antonwolfy and
vlad-perevezentsev
as code owners
antonwolfy
reviewed
Feb 5, 2025
antonwolfy
reviewed
Feb 5, 2025
vtavana
force-pushed
the
compare-shape
branch
from
2badc2f to
135df75
Compare
vtavana
force-pushed
the
compare-shape
branch
7 times, most recently
from
a47ee75 to
94c792e
Compare
antonwolfy
reviewed
Apr 30, 2025
antonwolfy
approved these changes
May 6, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vtavana for implementing that, no more comments from me.
github-actions bot
added a commit
that referenced
this pull request
May 15, 2025
In the test suite, the result arrays from `dpnp` and `numpy` were compared, but their shapes were not explicitly checked for equality. As a result, tests could pass even if the shapes differed, such as one being `(1,)` and the other `()`. This PR adds an explicit check to ensure that the output shapes of `numpy` and `dpnp` match. Additionally, tests have been updated accordingly to pass with this new check. e41ff80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test suite, the result arrays from
dpnpandnumpywere compared, but their shapes were not explicitly checked for equality. As a result, tests could pass even if the shapes differed, such as one being(1,)and the other().This PR adds an explicit check to ensure that the output shapes of
numpyanddpnpmatch. Additionally, tests have been updated accordingly to pass with this new check.