Fix search shuffle#23
Merged
Merged
Conversation
Also fix the results type (should be np.uint64) by making it implicit.
Member
Author
|
The initial search shuffle commit is broken. Sorry for rushing it. Can you please review this fix, @aguerreb? |
|
Could you review the comment I left before? The help message is confusing to me. Thanks! |
Member
Author
|
I couldn't find your comment. Could you please share a link? In any case, I rewrote the help messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix the results type (should be np.uint64) by making it implicit.
The NumPy upgrade is required for
same_valuecasting.