Skip to content

Conversation

@stighellemans
Copy link

Description

This pull request aims to fix several issues, as described in the issues section. It makes it possible to use LUCID-GAN in the edge cases and fixes some bugs of the code around the adult dataset.

It's important to mention that the folder 'illustration' only exists to illustrate the issues.

Fixes issues #6, #7, #8, #9

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    -> Not necessary
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
    -> See illustration folder
  • New and existing unit tests pass locally with my changes
    -> Not possible since I run into some trouble installing the dependencies of Keras/Tensorflow.
  • Any dependent changes have been merged and published in downstream modules

Critical improvements to let LUCID-GAN work in all edge cases.
Code formatted
Small docstring changes
Change to MakeFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants