-
Notifications
You must be signed in to change notification settings - Fork 2
Fill out implementation #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HastingsGreer
wants to merge
10
commits into
master
Choose a base branch
from
implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3892fb4
Update itk_torch_transform_bridge.py
HastingsGreer 7e58bb1
Create test_grid_sample.py
HastingsGreer e9f4f6f
Update test_grid_sample.py
HastingsGreer af64fa2
Create test-action.yml
HastingsGreer 5eae7af
Update test-action.yml
HastingsGreer 5a45c00
Create test_monai.py
HastingsGreer 32285c9
Update setup.cfg
HastingsGreer c3796f3
Update test-action.yml
HastingsGreer ba2c4f7
Update test-action.yml
HastingsGreer b7ba34c
Update test_monai.py
HastingsGreer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: test | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| test-linux: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| max-parallel: 5 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up Python 3.7 | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: 3.7 | ||
| - name: Install dependencies | ||
| run: | | ||
| pip install -e ".[testing]" | ||
|
|
||
| - name: test | ||
| run: | | ||
| python -m unittest discover |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import itk_torch_transform | ||
| import torch | ||
| import itk | ||
| import torch.nn.functional as F |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import torch | ||
| import monai | ||
| import unittest | ||
|
|
||
| class TestMonaiWarp(unittest.TestCase): | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may work for the types, but a cool best practice is to use for forward type declarations like this:
Examples:
https://github.com/InsightSoftwareConsortium/ITK/blob/c49d6379c575332e88de858cc2cf9529a40be625/Wrapping/Generators/Python/itk/support/extras.py#L1416-L1417
https://github.com/InsightSoftwareConsortium/ITK/blob/c49d6379c575332e88de858cc2cf9529a40be625/Wrapping/Generators/Python/itk/support/extras.py#L1183-L1188