COMP: Bump to minimum CMake 3.16.3 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
BumpMinReqCMakeVersion
branch
from
6f2bd48 to
47219b8
Compare
Bump to minimum CMake 3.16.3: use same `cmake_minimum_required` values as ITK. Bumped in ITK in commit InsightSoftwareConsortium/ITK@b01b325 Fixes: ``` -- cmake_minimum_required of 3.10.2 is not enough. CMake Warning at D:/a/ITKPrincipalComponentsAnalysis/ITK/CMake/ITKModuleExternal.cmake:15 (message): -- This is needed to allow proper setting of CMAKE_MSVC_RUNTIME_LIBRARY. -- Do not be surprised if you run into link errors of the style: LNK2038: mismatch detected for 'RuntimeLibrary': value 'MTd_Static' doesn't match value 'MDd_Dynamic' in module.obj cmake_minimum_required must be at least 3.16.3 ``` raised for example in: https://open.cdash.org/builds/10183591/configure
jhlegarreta
force-pushed
the
BumpMinReqCMakeVersion
branch
from
47219b8 to
ee6678b
Compare
dzenanz
approved these changes
Feb 2, 2025
Member
|
We should bump it to 3.22.1, as per: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to minimum CMake 3.16.3: use same
cmake_minimum_requiredvalues as ITK.Bumped in ITK in commit
InsightSoftwareConsortium/ITK@b01b325
Fixes:
raised for example in:
https://open.cdash.org/builds/10183591/configure