STYLE: Prefer using https instead of http in copyright notice
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer using `https` instead of `http` in copyright notice license link. Changed in InsightSoftwareConsortium/ITK#3428 Fixes: ``` /home/runner/work/ITKPolarTransform/ITKPolarTransform/include/itkCartesianToPolarTransform.h:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h /home/runner/work/ITKPolarTransform/ITKPolarTransform/include/itkCartesianToPolarTransform.hxx:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h /home/runner/work/ITKPolarTransform/ITKPolarTransform/include/itkPolarToCartesianTransform.h:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h /home/runner/work/ITKPolarTransform/ITKPolarTransform/include/itkPolarToCartesianTransform.hxx:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h /home/runner/work/ITKPolarTransform/ITKPolarTransform/test/itkPolarTransformTest.cxx:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h ``` raised for example in: https://github.com/InsightSoftwareConsortium/ITKPolarTransform/actions/runs/13094200407/job/36534462910#step:14:60
Member
Author
|
As said at the time, the original notice does not use My feeling is that the Apache folks would have fixed that if it was a source of problems, but anyways, now we have gone this way, so trying to fix these in the remaining remotes. |
dzenanz
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer using
httpsinstead ofhttpin copyright notice license link.Changed in InsightSoftwareConsortium/ITK#3428
Fixes:
raised for example in:
https://github.com/InsightSoftwareConsortium/ITKPolarTransform/actions/runs/13094200407/job/36534462910#step:14:60