Skip to content

COMP: Modernize CMake and update CI to v5.4.6 with OpenSlide system packages #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjmjohnson wants to merge 5 commits into
base: main
Choose a base branch
from
Open

COMP: Modernize CMake and update CI to v5.4.6 with OpenSlide system packages #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e90ced6
COMP: Re-enable CI with system package inputs for OpenSlide
hjmjohnson Apr 3, 2026
6eaa53b
COMP: Add module include/ to search path for src/ targets
hjmjohnson Apr 13, 2026
6e5e51b
COMP: Update CXX workflow ref to merged v5.4.6 branch
hjmjohnson Apr 13, 2026
c3b2c47
COMP: Add build directory to include path for export header
hjmjohnson Apr 14, 2026
4febb2d
COMP: Modernize CMake to itk_module_add_library and disable Python wh…
hjmjohnson Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/build-test-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,14 @@ on:

jobs:
cxx-build-workflow:
uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.2
uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.6
with:
apt-packages: 'libopenslide-dev'
brew-packages: 'openslide'
os-list: '["ubuntu-22.04", "macos-15-intel", "macos-15"]'

python-build-workflow:
uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@v5.4.2
secrets:
pypi_password: ${{ secrets.pypi_password }}
# Python wheel builds are disabled because OpenSlide is an external C
# library that is not available in the manylinux Docker containers or
# the Windows wheel-build environment. Re-enable when the Python
# workflow gains apt-packages / brew-packages support or the module
# bundles its own OpenSlide build.
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ classifiers = [
"Topic :: Scientific/Engineering :: Medical Science Apps.",
"Topic :: Software Development :: Libraries",
]
requires-python = ">=3.9"
requires-python = ">=3.10"
dependencies = [
"itk == 5.4.*",
]
Expand Down
7 changes: 2 additions & 5 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ set(IOOpenSlide_SRCS
itkOpenSlideImageIO.cxx
)

include_directories(${OPENSLIDE_INCLUDE_DIRS})

add_library(IOOpenSlide ${IOOpenSlide_SRCS})
itk_module_add_library(IOOpenSlide ${IOOpenSlide_SRCS})
target_include_directories(IOOpenSlide PRIVATE ${OPENSLIDE_INCLUDE_DIRS})
target_link_libraries(IOOpenSlide LINK_PRIVATE ${OPENSLIDE_LIBRARIES})
itk_module_link_dependencies()
itk_module_target(IOOpenSlide)
Loading