ENH: Add legacy Sobel option to GradientDifferenceImageToImageMetric #5739
+87
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Infrastructure
N-Dekker
force-pushed
the
GradientDifferenceImageToImageMetric-LegacySobelOperatorCoordinates
branch
from
34fc2e0 to
8b9ee7d
Compare
dzenanz
approved these changes
Jan 23, 2026
N-Dekker
changed the title
Contributor
Author
|
Member
|
@N-Dekker I think this is ready for rebase and review. |
Contributor
Author
Thanks Hans, but I'm still thinking of a slightly better unit test. One that really shows that the legacy option affects the output. To be continued. 🤷 |
N-Dekker
force-pushed
the
GradientDifferenceImageToImageMetric-LegacySobelOperatorCoordinates
branch
from
8b9ee7d to
01adb88
Compare
github-actions
bot
removed
type:Infrastructure
Added `UseLegacySobelOperatorCoordinates(bool)` member function, allowing to switch off `UseLegacyCoefficients` from the Sobel operators used by the metric. Added a complimentary member function, IsUsingLegacySobelOperatorCoordinates(). Follow-up to pull request InsightSoftwareConsortium#5735 commit e6d4997 "ENH: Add UseLegacyOperatorCoefficients to SobelEdgeDetectionImageFilter"
N-Dekker
force-pushed
the
GradientDifferenceImageToImageMetric-LegacySobelOperatorCoordinates
branch
from
01adb88 to
e049158
Compare
N-Dekker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
UseLegacySobelOperatorCoordinates(bool)member function, allowing to switch offUseLegacyCoefficientsfrom the Sobel operators used by the metric.Added a complimentary member function, IsUsingLegacySobelOperatorCoordinates().
Follow-up to pull request #5735 commit e6d4997
"ENH: Add UseLegacyOperatorCoefficients to SobelEdgeDetectionImageFilter"