STYLE: Make NumericTraits::GetLength constexpr whenever possible
#5671
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that most `NumericTraits` specializations can have constexpr `GetLength` member functions. The only `NumericTraits` specializations whose `GetLength` member functions cannot be constexpr are for `std::vector` and `VariableLengthVector`
github-actions
bot
added
area:Core
hjmjohnson
approved these changes
Dec 4, 2025
dzenanz
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that most
NumericTraitsspecializations can have constexprGetLengthmember functions. The onlyNumericTraitsspecializations whoseGetLengthmember functions cannot be constexpr are forstd::vectorandVariableLengthVectorNumericTraits::GetLengthis very fast, and can often be evaluated at compile-time.