Skip to content

STYLE: Remove redundant overrides of Get and Set member functions#2833

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Remove-redundant-Get-Set-overrides
Oct 25, 2021
Merged

STYLE: Remove redundant overrides of Get and Set member functions#2833
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Remove-redundant-Get-Set-overrides

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker commented Oct 21, 2021

Removed redundant overrides of the following member functions:

TransformParametersAdaptorBase::GetRequiredFixedParameters()
ObjectToObjectMetric::GetNumberOfValidPoints()
ObjectToObjectOptimizerBaseTemplate::SetNumberOfIterations(SizeValueType)
ObjectToObjectOptimizerBaseTemplate::GetNumberOfIterations()
ObjectToObjectOptimizerBaseTemplate::GetCurrentIteration()

These overrides did just the same as the member functions that they did
override.

Removed redundant overrides of the following member functions:

    TransformParametersAdaptorBase::GetRequiredFixedParameters()
    ObjectToObjectMetric::GetNumberOfValidPoints()
    ObjectToObjectOptimizerBaseTemplate::SetNumberOfIterations(SizeValueType)
    ObjectToObjectOptimizerBaseTemplate::GetNumberOfIterations()
    ObjectToObjectOptimizerBaseTemplate::GetCurrentIteration()

These overrides did just the same as the member functions that they did
override.
@github-actions github-actions Bot added area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Style Style changes: no logic impact (indentation, comments, naming) labels Oct 21, 2021
@N-Dekker
Copy link
Copy Markdown
Contributor Author

Cherry-picked from the first commit of pull request #2785 (Remove virtual from Get/Set macro definitions)

@dzenanz dzenanz merged commit 5b155ae into InsightSoftwareConsortium:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants