Skip to content

Update health probe path to new one#1064

Merged
olevitt merged 2 commits intomainfrom
fix-onboarding-health-probes
Mar 13, 2026
Merged

Update health probe path to new one#1064
olevitt merged 2 commits intomainfrom
fix-onboarding-health-probes

Conversation

@nicolst
Copy link
Contributor

@nicolst nicolst commented Mar 13, 2026

Health probes fail for the latest chart version because the newer versions of onyxia-onboarding changed the endpoint from / to /healthz

Summary by CodeRabbit

  • Bug Fixes

    • Corrected health-check probe paths for liveness, readiness, and startup to the proper endpoint.
  • Chores

    • Bumped Helm chart version to 10.32.7.

Health probes fail for the latest chart version because the newer versions of onyxia-onboarding changed the endpoint from / to /healthz
@nicolst nicolst requested a review from ddecrulle March 13, 2026 09:18
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 795bffa8-2c20-48d9-baa1-929a227b8b37

📥 Commits

Reviewing files that changed from the base of the PR and between 30cb55a and f398f71.

📒 Files selected for processing (1)
  • helm-chart/Chart.yaml

📝 Walkthrough

Walkthrough

Update Helm chart: change onboarding liveness/readiness/startup probe paths from "/" to "/healthz" and bump chart version from 10.32.6 to 10.32.7. No other probe settings or exported signatures changed.

Changes

Cohort / File(s) Summary
Health Check Probe Configuration
helm-chart/values.yaml
Updated onboarding liveness, readiness, and startup probe path from "/" to "/healthz". No timing or other probe settings changed.
Chart Metadata
helm-chart/Chart.yaml
Bumped chart version from 10.32.6 to 10.32.7. No other metadata changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through charts and values bright,
Swapped "/" for "/healthz" — now all feels right,
A version nudge, a tiny cheer,
Small changes made, the path is clear! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using imprecise language like 'new one' that doesn't specify which path or endpoint is being updated. Consider a more specific title such as 'Update onboarding health probe path from / to /healthz' to clearly communicate the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-onboarding-health-probes
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

@olevitt
Copy link
Contributor

olevitt commented Mar 13, 2026

@nicolst are you sure you are running on a recent onyxia-onboarding image ? You should be running 0.1.19 (helm chart default) / 0.1.20.
The healthcheck is on /healthz since v0.1.12 see https://github.com/onyxia-datalab/onyxia-backend/blob/8152359be3509e171f0f03c440885e77640621fd/cmd/onyxia-onboarding/main.go#L41
and onyxia-datalab/onyxia-backend@cd10835

@nicolst
Copy link
Contributor Author

nicolst commented Mar 13, 2026

Yes, the health endpoint has been /healthz for a while, but this is not reflected in the chart values

@olevitt
Copy link
Contributor

olevitt commented Mar 13, 2026

yeah mybad, you are totally right. Let's merge this, thanks ! 👍

@sonarqubecloud
Copy link

@olevitt olevitt merged commit fefb02c into main Mar 13, 2026
4 of 5 checks passed
@olevitt olevitt deleted the fix-onboarding-health-probes branch March 13, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants