[IC-988] Update API docs for v1.19.0 chain upgrade#185
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated pinned dependency versions in the Makefile, refined proto discovery logic in a script, standardized Go examples to load environment variables for private keys, added voucher-related auction/insurance docs, and simplified many auto-generated JSON/table type names across documentation files. Changes
*Files with Go env/key changes include (non-exhaustive): Sequence Diagram(s)(omitted — changes do not introduce a new multi-component runtime control flow requiring a sequence diagram) Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
source/includes/_authz.md (1)
404-425:⚠️ Potential issue | 🟠 MajorUse distinct private-key env vars for granter and grantee in
MsgExecexample.Both
InitCosmosKeyringcalls currently readINJECTIVE_PRIVATE_KEY, so the example cannot represent two principals reliably (and conflicts with the delegated-execution narrative).🔧 Proposed fix
granterAddress, _, err := chainclient.InitCosmosKeyring( os.Getenv("HOME")+"/.injectived", "injectived", "file", - "inj-user", + "inj-granter", "12345678", - os.Getenv("INJECTIVE_PRIVATE_KEY"), // keyring will be used if pk not provided + os.Getenv("INJECTIVE_GRANTER_PRIVATE_KEY"), // keyring will be used if pk not provided false, ) @@ senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( os.Getenv("HOME")+"/.injectived", "injectived", "file", - "inj-user", + "inj-grantee", "12345678", - os.Getenv("INJECTIVE_PRIVATE_KEY"), // keyring will be used if pk not provided + os.Getenv("INJECTIVE_GRANTEE_PRIVATE_KEY"), // keyring will be used if pk not provided false, )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/includes/_authz.md` around lines 404 - 425, The example uses the same env var INJECTIVE_PRIVATE_KEY for both InitCosmosKeyring calls (granterAddress and senderAddress), which prevents showing two distinct principals; update the second call to use a different env var (e.g., INJECTIVE_PRIVATE_KEY_GRANTEE or INJECTIVE_PRIVATE_KEY_SENDER) and adjust any surrounding comments to reflect granter vs grantee so that InitCosmosKeyring is invoked with two distinct private-key environment variables for granter and grantee.source/includes/_bank.md (1)
102-116:⚠️ Potential issue | 🟡 MinorDocument runtime prerequisites for env-based auth.
Lines 102 and 115 moved credentials to env-based loading, but this section does not tell readers to set
INJECTIVE_PRIVATE_KEY(or.env) before running examples. That causes avoidable run failures/confusion.🛠️ Suggested docs addition (apply in the generator/template so all snippets get it)
### Request Parameters > Request Example: +> +> **Prerequisites** +> - Set `INJECTIVE_PRIVATE_KEY` in your shell or `.env` file. +> - Ensure your environment is loaded before running the Go examples.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/includes/_bank.md` around lines 102 - 116, Add a short runtime prerequisites note telling users to set the INJECTIVE_PRIVATE_KEY env (or provide a .env file) before running the examples that call godotenv.Load() and chainclient.InitCosmosKeyring; mention that InitCosmosKeyring will fallback to the file keyring only if INJECTIVE_PRIVATE_KEY is absent, show the required env variable name (INJECTIVE_PRIVATE_KEY) and briefly how to provide it (export INJECTIVE_PRIVATE_KEY or place it in .env) so examples that call godotenv.Load() and use network/TmEndpoint succeed.source/includes/_permissions.md (1)
2048-2048:⚠️ Potential issue | 🟠 MajorFix incorrect RPC method in PolicyManagerCapabilities example.
Line 2048 calls
FetchPermissionsPolicyStatuses, but the PolicyManagerCapabilities section should useFetchPermissionsPolicyManagerCapabilities(consistent with the Python SDK example in the same section).Diff
- res, err := chainClient.FetchPermissionsPolicyStatuses(ctx, denom) + res, err := chainClient.FetchPermissionsPolicyManagerCapabilities(ctx, denom)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/includes/_permissions.md` at line 2048, The example in the PolicyManagerCapabilities section incorrectly calls chainClient.FetchPermissionsPolicyStatuses; change this call to chainClient.FetchPermissionsPolicyManagerCapabilities so it matches the Python SDK example and the intended RPC, and update any variable names or expected return handling in that example to match the FetchPermissionsPolicyManagerCapabilities signature (e.g., response and error handling) to ensure the example compiles and accurately demonstrates PolicyManagerCapabilities usage.
🧹 Nitpick comments (6)
source/json_tables/cometbft/abci/v1beta2/Request_Commit.json (1)
5-5: Consider adding a description.The
Descriptionfield is empty, which may reduce documentation value for API consumers. While this is a pre-existing issue, adding a brief description of the commit parameter would improve the documentation quality.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/json_tables/cometbft/abci/v1beta2/Request_Commit.json` at line 5, The Request_Commit JSON currently has an empty "Description" for the Request_Commit object; update the "Description" field in Request_Commit.json to a concise sentence explaining what the commit request represents (e.g., that it requests the node to commit the current state and return the commit response including last block height and state hash) so API consumers understand the purpose of Request_Commit and its returned commit parameters.source/json_tables/cosmos/auth/QueryAccountsResponse.json (1)
4-4: Consider disambiguatingAny arrayfor reader clarity.
PageResponseis great, butAny arraycan be interpreted generically. Consider a clearer label (e.g.,protobuf.Any array) or a short description note to avoid ambiguity for API consumers.Also applies to: 9-9
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/json_tables/cosmos/auth/QueryAccountsResponse.json` at line 4, Update the ambiguous type label "Any array" in the JSON schema to a clearer description so readers know it refers to protobuf Any messages (e.g., change the Type value from "Any array" to "protobuf.Any array" or "array of protobuf Any"); apply the same change where "Any array" appears (including the other occurrence noted) and optionally add a short description field or comment mentioning these are protobuf Any messages used for heterogeneous account payloads to avoid ambiguity for API consumers referencing PageResponse.source/includes/_derivativesrpc.md (1)
1853-1853: Consider clearer enum formatting forexecution_side.The new values are correct, but formatting them with spaces/backticks would improve readability in generated docs (e.g.,
maker,taker,n/a).Also applies to: 2191-2191, 4410-4410
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/includes/_derivativesrpc.md` at line 1853, Update the description for the execution_side parameter to show the enum values as inline code and separated by commas (e.g., `maker`, `taker`, `n/a`) so generated docs render clearly; specifically edit the execution_side description text (symbol: execution_side) to use backticks around each value and include spaces after commas and apply the same change to the other two occurrences referenced (the other execution_side entries around the noted locations).source/includes/_staking.md (1)
1385-1387: StandardizePrivateKeyimport path across Python snippets.The file uses both
from pyinjective import PrivateKeyandfrom pyinjective.wallet import PrivateKey. Per official pyinjective documentation (v1.13.1), the canonical import isfrom pyinjective.wallet import PrivateKey. Update lines 1385–1387 and 2041–2043 to use this standard path for consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/includes/_staking.md` around lines 1385 - 1387, Replace the non-canonical PrivateKey import so all Python snippets use the documented path: change any occurrence of "from pyinjective import PrivateKey" to "from pyinjective.wallet import PrivateKey" (e.g., the snippet that currently imports PrivateKey with AsyncClient and MsgBroadcasterWithPk and the later similar snippet around the AsyncClient usage); keep the other imports (AsyncClient, MsgBroadcasterWithPk) unchanged.source/includes/_wasm.md (1)
1938-1938: Consider harmonizingCoinsvsCointerminology in adjacent docs sections.Nearby sections use both
CoinsandCoin; picking one convention (e.g.,Coin array) would reduce reader ambiguity.Also applies to: 1947-1947, 2093-2093, 2102-2102
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/includes/_wasm.md` at line 1938, The doc uses both "Coins" and "Coin" for the same concept (see the funds parameter type shown as "Coins"); standardize the terminology across the WASM docs by replacing all occurrences of "Coins" and lone "Coin" type labels (including the funds parameter and the nearby entries) with a single consistent form such as "Coin array" or "Coin[]" (choose one convention and apply it consistently to the funds parameter and the other mentioned occurrences).source/includes/_auction.md (1)
57-57: Handlegodotenv.Load()errors for better developer experience.The error from
godotenv.Load()is silently discarded. If the.envfile is missing or malformed, the code will continue with empty environment variables, potentially causing cryptic failures later whenos.Getenv("INJECTIVE_PRIVATE_KEY")returns an empty string.🔍 Suggested improvement
- _ = godotenv.Load() + if err := godotenv.Load(); err != nil { + // .env file is optional, but log if there's an issue loading it + fmt.Printf("Warning: Error loading .env file: %v\n", err) + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/includes/_auction.md` at line 57, The call that discards the error from godotenv.Load() should handle failures: replace "_ = godotenv.Load()" with code that captures the returned error from godotenv.Load(), checks it, and either logs a clear error (including the error value) and exits (e.g., log.Fatalf / process exit) or returns the error up the stack so the program fails fast when the .env cannot be loaded; reference the godotenv.Load() call and any downstream use of os.Getenv("INJECTIVE_PRIVATE_KEY") to ensure you surface a helpful message like "failed to load .env" plus the underlying error.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Makefile`:
- Around line 2-23: INJECTIVE_CORE_REPO and INDEXER_REPO point to non-existent
GitHub URLs and will break the build; locate the correct repositories or
organization (or their new names) and update the Makefile variables
INJECTIVE_CORE_REPO and INDEXER_REPO to the valid GitHub repository URLs, and if
the tags v1.19.0 don't exist there also update INJECTIVE_CORE_VERSION and
INDEXER_VERSION to the correct tags (or remove pinning), then re-run a git/tag
check to ensure the URLs and versions resolve successfully.
In `@scripts/generate_proto_json_files.sh`:
- Around line 450-457: The branch logic can skip nested .pb.go files and the
find pipeline is fragile; modify the conditionals so you do not use an elif that
prevents both checks — e.g., first check for any .pb.go anywhere under
module_dir using find with -print -quit and test its exit status (avoid piping
to head/grep), and separately check for direct files with compgen to call
process_directory for root-level .pb.go and process_repository_modules for
nested/namespace modules (or run both paths as appropriate); update the find
invocation to use "find \"$module_dir\" -name \"*.pb.go\" -type f -print -quit"
and use its exit code to decide calling process_repository_modules, while
keeping process_directory invocation for direct matches (functions:
process_directory, process_repository_modules; variable: module_dir,
module_name).
In `@source/includes/_account.md`:
- Line 208: Update the parameter description for tx_response to use singular
phrasing: replace "tx_response is the queried TxResponses." with "tx_response is
the queried TxResponse." and apply the same singular fix for every other
occurrence where the tx_response parameter description currently uses "queried
TxResponses" so all descriptions for the tx_response parameter are consistent
and singular.
In `@source/includes/_derivativesrpc.md`:
- Line 2528: The upnl field description contains a duplicated word "with
with_upnl=true"; update the description for the parameter named "upnl" in
source/includes/_derivativesrpc.md to remove the duplicate and use correct
phrasing (e.g., "only present when requested with upnl=true" or "only present
when with_upnl=true" consistently), and fix the same duplicated wording at the
other occurrence mentioned (the second "upnl" description around the later
occurrence). Ensure both occurrences reference the same, corrected form.
In `@source/includes/_insurance.md`:
- Around line 122-124: There are empty response example JSON blocks in
source/includes/_insurance.md (notably the three empty ```json``` blocks around
the new endpoint sections); replace each empty block with concrete sample
response payloads that match the endpoint schemas (include typical fields, data
types, nested objects/arrays, and an example of success and common error
response where relevant), locating the blocks by looking for the empty
triple-backtick json fences under the new endpoint headings in that file and
updating them with realistic example JSON bodies that consumers can use for
integration testing.
In `@source/includes/_oraclerpc.md`:
- Line 697: Heading "StreamPricesByMarket" is inconsistent with the RPC/method
name used elsewhere; change the section title to "StreamPricesByMarkets" so it
matches the request file and examples, and update any in-page references or
links that point to the old singular name (look for occurrences of
StreamPricesByMarket and replace them with StreamPricesByMarkets).
In `@source/includes/_tendermint.md`:
- Line 1268: Update the pagination description text in
source/includes/_tendermint.md: replace the incorrect phrase "defines an
pagination for the request." with "defines a pagination for the request." for
the table entry where the Parameter is "pagination" (and likewise fix the same
phrase in the other occurrences referenced around the file, e.g., the rows at
the other instances noted); ensure the exact wording change is applied to each
table cell containing "defines an pagination" so all occurrences are corrected.
In `@source/includes/_tokenfactory.md`:
- Line 578: The parameter docs for denom_creation_fee use an inconsistent type
name ("Coins") while nearby documentation uses "Coin"; update the
denom_creation_fee type to a consistent representation — either change "Coins"
to "Coin array" in the parameter table for denom_creation_fee, or add a
dedicated "Coins" type block that documents it as an array alias; ensure
references to denom_creation_fee and the Coin/Coin array naming are consistent
across this section.
---
Outside diff comments:
In `@source/includes/_authz.md`:
- Around line 404-425: The example uses the same env var INJECTIVE_PRIVATE_KEY
for both InitCosmosKeyring calls (granterAddress and senderAddress), which
prevents showing two distinct principals; update the second call to use a
different env var (e.g., INJECTIVE_PRIVATE_KEY_GRANTEE or
INJECTIVE_PRIVATE_KEY_SENDER) and adjust any surrounding comments to reflect
granter vs grantee so that InitCosmosKeyring is invoked with two distinct
private-key environment variables for granter and grantee.
In `@source/includes/_bank.md`:
- Around line 102-116: Add a short runtime prerequisites note telling users to
set the INJECTIVE_PRIVATE_KEY env (or provide a .env file) before running the
examples that call godotenv.Load() and chainclient.InitCosmosKeyring; mention
that InitCosmosKeyring will fallback to the file keyring only if
INJECTIVE_PRIVATE_KEY is absent, show the required env variable name
(INJECTIVE_PRIVATE_KEY) and briefly how to provide it (export
INJECTIVE_PRIVATE_KEY or place it in .env) so examples that call godotenv.Load()
and use network/TmEndpoint succeed.
In `@source/includes/_permissions.md`:
- Line 2048: The example in the PolicyManagerCapabilities section incorrectly
calls chainClient.FetchPermissionsPolicyStatuses; change this call to
chainClient.FetchPermissionsPolicyManagerCapabilities so it matches the Python
SDK example and the intended RPC, and update any variable names or expected
return handling in that example to match the
FetchPermissionsPolicyManagerCapabilities signature (e.g., response and error
handling) to ensure the example compiles and accurately demonstrates
PolicyManagerCapabilities usage.
---
Nitpick comments:
In `@source/includes/_auction.md`:
- Line 57: The call that discards the error from godotenv.Load() should handle
failures: replace "_ = godotenv.Load()" with code that captures the returned
error from godotenv.Load(), checks it, and either logs a clear error (including
the error value) and exits (e.g., log.Fatalf / process exit) or returns the
error up the stack so the program fails fast when the .env cannot be loaded;
reference the godotenv.Load() call and any downstream use of
os.Getenv("INJECTIVE_PRIVATE_KEY") to ensure you surface a helpful message like
"failed to load .env" plus the underlying error.
In `@source/includes/_derivativesrpc.md`:
- Line 1853: Update the description for the execution_side parameter to show the
enum values as inline code and separated by commas (e.g., `maker`, `taker`,
`n/a`) so generated docs render clearly; specifically edit the execution_side
description text (symbol: execution_side) to use backticks around each value and
include spaces after commas and apply the same change to the other two
occurrences referenced (the other execution_side entries around the noted
locations).
In `@source/includes/_staking.md`:
- Around line 1385-1387: Replace the non-canonical PrivateKey import so all
Python snippets use the documented path: change any occurrence of "from
pyinjective import PrivateKey" to "from pyinjective.wallet import PrivateKey"
(e.g., the snippet that currently imports PrivateKey with AsyncClient and
MsgBroadcasterWithPk and the later similar snippet around the AsyncClient
usage); keep the other imports (AsyncClient, MsgBroadcasterWithPk) unchanged.
In `@source/includes/_wasm.md`:
- Line 1938: The doc uses both "Coins" and "Coin" for the same concept (see the
funds parameter type shown as "Coins"); standardize the terminology across the
WASM docs by replacing all occurrences of "Coins" and lone "Coin" type labels
(including the funds parameter and the nearby entries) with a single consistent
form such as "Coin array" or "Coin[]" (choose one convention and apply it
consistently to the funds parameter and the other mentioned occurrences).
In `@source/json_tables/cometbft/abci/v1beta2/Request_Commit.json`:
- Line 5: The Request_Commit JSON currently has an empty "Description" for the
Request_Commit object; update the "Description" field in Request_Commit.json to
a concise sentence explaining what the commit request represents (e.g., that it
requests the node to commit the current state and return the commit response
including last block height and state hash) so API consumers understand the
purpose of Request_Commit and its returned commit parameters.
In `@source/json_tables/cosmos/auth/QueryAccountsResponse.json`:
- Line 4: Update the ambiguous type label "Any array" in the JSON schema to a
clearer description so readers know it refers to protobuf Any messages (e.g.,
change the Type value from "Any array" to "protobuf.Any array" or "array of
protobuf Any"); apply the same change where "Any array" appears (including the
other occurrence noted) and optionally add a short description field or comment
mentioning these are protobuf Any messages used for heterogeneous account
payloads to avoid ambiguity for API consumers referencing PageResponse.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7a075e69-230d-41cb-92d4-0298a7484083
📒 Files selected for processing (300)
Makefilescripts/generate_proto_json_files.shsource/includes/_account.mdsource/includes/_auction.mdsource/includes/_authz.mdsource/includes/_bank.mdsource/includes/_binaryoptions.mdsource/includes/_chainexchange.mdsource/includes/_chainstream.mdsource/includes/_changelog.mdsource/includes/_derivatives.mdsource/includes/_derivativesrpc.mdsource/includes/_erc20.mdsource/includes/_errors.mdsource/includes/_evm.mdsource/includes/_explorerrpc.mdsource/includes/_ibccorechannel.mdsource/includes/_ibccoreclient.mdsource/includes/_ibccoreconnection.mdsource/includes/_ibctransfer.mdsource/includes/_insurance.mdsource/includes/_oracle.mdsource/includes/_oraclerpc.mdsource/includes/_permissions.mdsource/includes/_spot.mdsource/includes/_spotrpc.mdsource/includes/_staking.mdsource/includes/_tendermint.mdsource/includes/_tokenfactory.mdsource/includes/_txfees.mdsource/includes/_wasm.mdsource/includes/_wasmx.mdsource/json_tables/cometbft/abci/v1/ExtendVoteRequest.jsonsource/json_tables/cometbft/abci/v1/ExtendedVoteInfo.jsonsource/json_tables/cometbft/abci/v1/FinalizeBlockRequest.jsonsource/json_tables/cometbft/abci/v1/FinalizeBlockResponse.jsonsource/json_tables/cometbft/abci/v1/InitChainRequest.jsonsource/json_tables/cometbft/abci/v1/InitChainResponse.jsonsource/json_tables/cometbft/abci/v1/Misbehavior.jsonsource/json_tables/cometbft/abci/v1/PrepareProposalRequest.jsonsource/json_tables/cometbft/abci/v1/ProcessProposalRequest.jsonsource/json_tables/cometbft/abci/v1/QueryResponse.jsonsource/json_tables/cometbft/abci/v1/VoteInfo.jsonsource/json_tables/cometbft/abci/v1beta1/ConsensusParams.jsonsource/json_tables/cometbft/abci/v1beta1/Evidence.jsonsource/json_tables/cometbft/abci/v1beta1/RequestBeginBlock.jsonsource/json_tables/cometbft/abci/v1beta1/RequestInitChain.jsonsource/json_tables/cometbft/abci/v1beta1/ResponseQuery.jsonsource/json_tables/cometbft/abci/v1beta1/ValidatorUpdate.jsonsource/json_tables/cometbft/abci/v1beta2/CommitInfo.jsonsource/json_tables/cometbft/abci/v1beta2/ExtendedVoteInfo.jsonsource/json_tables/cometbft/abci/v1beta2/Misbehavior.jsonsource/json_tables/cometbft/abci/v1beta2/RequestBeginBlock.jsonsource/json_tables/cometbft/abci/v1beta2/RequestInitChain.jsonsource/json_tables/cometbft/abci/v1beta2/RequestPrepareProposal.jsonsource/json_tables/cometbft/abci/v1beta2/RequestProcessProposal.jsonsource/json_tables/cometbft/abci/v1beta2/Request_ApplySnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta2/Request_CheckTx.jsonsource/json_tables/cometbft/abci/v1beta2/Request_Commit.jsonsource/json_tables/cometbft/abci/v1beta2/Request_DeliverTx.jsonsource/json_tables/cometbft/abci/v1beta2/Request_Echo.jsonsource/json_tables/cometbft/abci/v1beta2/Request_EndBlock.jsonsource/json_tables/cometbft/abci/v1beta2/Request_Flush.jsonsource/json_tables/cometbft/abci/v1beta2/Request_ListSnapshots.jsonsource/json_tables/cometbft/abci/v1beta2/Request_LoadSnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta2/Request_OfferSnapshot.jsonsource/json_tables/cometbft/abci/v1beta2/Request_Query.jsonsource/json_tables/cometbft/abci/v1beta2/ResponseEndBlock.jsonsource/json_tables/cometbft/abci/v1beta2/ResponseInitChain.jsonsource/json_tables/cometbft/abci/v1beta2/Response_ApplySnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta2/Response_Commit.jsonsource/json_tables/cometbft/abci/v1beta2/Response_Echo.jsonsource/json_tables/cometbft/abci/v1beta2/Response_Exception.jsonsource/json_tables/cometbft/abci/v1beta2/Response_Flush.jsonsource/json_tables/cometbft/abci/v1beta2/Response_Info.jsonsource/json_tables/cometbft/abci/v1beta2/Response_ListSnapshots.jsonsource/json_tables/cometbft/abci/v1beta2/Response_LoadSnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta2/Response_OfferSnapshot.jsonsource/json_tables/cometbft/abci/v1beta2/Response_Query.jsonsource/json_tables/cometbft/abci/v1beta3/ExecTxResult.jsonsource/json_tables/cometbft/abci/v1beta3/ExtendedVoteInfo.jsonsource/json_tables/cometbft/abci/v1beta3/RequestExtendVote.jsonsource/json_tables/cometbft/abci/v1beta3/RequestFinalizeBlock.jsonsource/json_tables/cometbft/abci/v1beta3/RequestInitChain.jsonsource/json_tables/cometbft/abci/v1beta3/RequestPrepareProposal.jsonsource/json_tables/cometbft/abci/v1beta3/RequestProcessProposal.jsonsource/json_tables/cometbft/abci/v1beta3/Request_ApplySnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta3/Request_CheckTx.jsonsource/json_tables/cometbft/abci/v1beta3/Request_Commit.jsonsource/json_tables/cometbft/abci/v1beta3/Request_Echo.jsonsource/json_tables/cometbft/abci/v1beta3/Request_Flush.jsonsource/json_tables/cometbft/abci/v1beta3/Request_Info.jsonsource/json_tables/cometbft/abci/v1beta3/Request_ListSnapshots.jsonsource/json_tables/cometbft/abci/v1beta3/Request_LoadSnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta3/Request_OfferSnapshot.jsonsource/json_tables/cometbft/abci/v1beta3/Request_Query.jsonsource/json_tables/cometbft/abci/v1beta3/ResponseCheckTx.jsonsource/json_tables/cometbft/abci/v1beta3/ResponseFinalizeBlock.jsonsource/json_tables/cometbft/abci/v1beta3/ResponseInitChain.jsonsource/json_tables/cometbft/abci/v1beta3/Response_ApplySnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta3/Response_Echo.jsonsource/json_tables/cometbft/abci/v1beta3/Response_Exception.jsonsource/json_tables/cometbft/abci/v1beta3/Response_Flush.jsonsource/json_tables/cometbft/abci/v1beta3/Response_Info.jsonsource/json_tables/cometbft/abci/v1beta3/Response_ListSnapshots.jsonsource/json_tables/cometbft/abci/v1beta3/Response_LoadSnapshotChunk.jsonsource/json_tables/cometbft/abci/v1beta3/Response_OfferSnapshot.jsonsource/json_tables/cometbft/abci/v1beta3/Response_PrepareProposal.jsonsource/json_tables/cometbft/abci/v1beta3/Response_ProcessProposal.jsonsource/json_tables/cometbft/abci/v1beta3/Response_Query.jsonsource/json_tables/cometbft/abci/v1beta3/VoteInfo.jsonsource/json_tables/cometbft/blocksync/v1/BlockResponse.jsonsource/json_tables/cometbft/blocksync/v1beta1/BlockResponse.jsonsource/json_tables/cometbft/consensus/v1/BlockPart.jsonsource/json_tables/cometbft/consensus/v1/HasVote.jsonsource/json_tables/cometbft/consensus/v1/MsgInfo.jsonsource/json_tables/cometbft/consensus/v1/NewValidBlock.jsonsource/json_tables/cometbft/consensus/v1/Proposal.jsonsource/json_tables/cometbft/consensus/v1/ProposalPOL.jsonsource/json_tables/cometbft/consensus/v1/TimedWALMessage.jsonsource/json_tables/cometbft/consensus/v1/TimeoutInfo.jsonsource/json_tables/cometbft/consensus/v1/Vote.jsonsource/json_tables/cometbft/consensus/v1/VoteSetBits.jsonsource/json_tables/cometbft/consensus/v1/VoteSetMaj23.jsonsource/json_tables/cometbft/consensus/v1/WALMessage_EventDataRoundState.jsonsource/json_tables/cometbft/consensus/v1beta1/BlockPart.jsonsource/json_tables/cometbft/consensus/v1beta1/HasVote.jsonsource/json_tables/cometbft/consensus/v1beta1/NewValidBlock.jsonsource/json_tables/cometbft/consensus/v1beta1/Proposal.jsonsource/json_tables/cometbft/consensus/v1beta1/ProposalPOL.jsonsource/json_tables/cometbft/consensus/v1beta1/TimedWALMessage.jsonsource/json_tables/cometbft/consensus/v1beta1/TimeoutInfo.jsonsource/json_tables/cometbft/consensus/v1beta1/Vote.jsonsource/json_tables/cometbft/consensus/v1beta1/VoteSetBits.jsonsource/json_tables/cometbft/consensus/v1beta1/VoteSetMaj23.jsonsource/json_tables/cometbft/consensus/v1beta1/WALMessage_EventDataRoundState.jsonsource/json_tables/cometbft/p2p/v1/AuthSigMessage.jsonsource/json_tables/cometbft/privval/v1/SignProposalRequest.jsonsource/json_tables/cometbft/privval/v1/SignVoteRequest.jsonsource/json_tables/cometbft/privval/v1/SignedProposalResponse.jsonsource/json_tables/cometbft/privval/v1/SignedVoteResponse.jsonsource/json_tables/cometbft/privval/v1beta1/PubKeyResponse.jsonsource/json_tables/cometbft/privval/v1beta1/SignProposalRequest.jsonsource/json_tables/cometbft/privval/v1beta1/SignVoteRequest.jsonsource/json_tables/cometbft/privval/v1beta1/SignedProposalResponse.jsonsource/json_tables/cometbft/privval/v1beta1/SignedVoteResponse.jsonsource/json_tables/cometbft/privval/v1beta2/PubKeyResponse.jsonsource/json_tables/cometbft/privval/v1beta2/SignProposalRequest.jsonsource/json_tables/cometbft/privval/v1beta2/SignVoteRequest.jsonsource/json_tables/cometbft/privval/v1beta2/SignedProposalResponse.jsonsource/json_tables/cometbft/privval/v1beta2/SignedVoteResponse.jsonsource/json_tables/cometbft/rpc/grpc/v1beta1/ResponseBroadcastTx.jsonsource/json_tables/cometbft/rpc/grpc/v1beta2/ResponseBroadcastTx.jsonsource/json_tables/cometbft/rpc/grpc/v1beta3/ResponseBroadcastTx.jsonsource/json_tables/cometbft/services/block/v1/GetByHeightResponse.jsonsource/json_tables/cometbft/services/block_results/v1/GetBlockResultsResponse.jsonsource/json_tables/cometbft/state/v1/ABCIResponsesInfo.jsonsource/json_tables/cometbft/state/v1/ConsensusParamsInfo.jsonsource/json_tables/cometbft/state/v1/LegacyABCIResponses.jsonsource/json_tables/cometbft/state/v1/ResponseBeginBlock.jsonsource/json_tables/cometbft/state/v1/ResponseEndBlock.jsonsource/json_tables/cometbft/state/v1/State.jsonsource/json_tables/cometbft/state/v1/ValidatorsInfo.jsonsource/json_tables/cometbft/state/v1/Version.jsonsource/json_tables/cometbft/state/v1beta1/ABCIResponses.jsonsource/json_tables/cometbft/state/v1beta1/ConsensusParamsInfo.jsonsource/json_tables/cometbft/state/v1beta1/State.jsonsource/json_tables/cometbft/state/v1beta1/ValidatorsInfo.jsonsource/json_tables/cometbft/state/v1beta1/Version.jsonsource/json_tables/cometbft/state/v1beta2/ABCIResponses.jsonsource/json_tables/cometbft/state/v1beta2/ConsensusParamsInfo.jsonsource/json_tables/cometbft/state/v1beta2/State.jsonsource/json_tables/cometbft/state/v1beta3/ABCIResponsesInfo.jsonsource/json_tables/cometbft/state/v1beta3/ConsensusParamsInfo.jsonsource/json_tables/cometbft/state/v1beta3/LegacyABCIResponses.jsonsource/json_tables/cometbft/state/v1beta3/ResponseBeginBlock.jsonsource/json_tables/cometbft/state/v1beta3/ResponseEndBlock.jsonsource/json_tables/cometbft/state/v1beta3/State.jsonsource/json_tables/cometbft/types/v1/CanonicalProposal.jsonsource/json_tables/cometbft/types/v1/CanonicalVote.jsonsource/json_tables/cometbft/types/v1/CommitSig.jsonsource/json_tables/cometbft/types/v1/DuplicateVoteEvidence.jsonsource/json_tables/cometbft/types/v1/EvidenceParams.jsonsource/json_tables/cometbft/types/v1/ExtendedCommitSig.jsonsource/json_tables/cometbft/types/v1/FeatureParams.jsonsource/json_tables/cometbft/types/v1/Header.jsonsource/json_tables/cometbft/types/v1/LightClientAttackEvidence.jsonsource/json_tables/cometbft/types/v1/Part.jsonsource/json_tables/cometbft/types/v1/Proposal.jsonsource/json_tables/cometbft/types/v1/SimpleValidator.jsonsource/json_tables/cometbft/types/v1/SynchronyParams.jsonsource/json_tables/cometbft/types/v1/TxProof.jsonsource/json_tables/cometbft/types/v1/Validator.jsonsource/json_tables/cometbft/types/v1/Vote.jsonsource/json_tables/cometbft/types/v1beta1/CanonicalProposal.jsonsource/json_tables/cometbft/types/v1beta1/CanonicalVote.jsonsource/json_tables/cometbft/types/v1beta1/CommitSig.jsonsource/json_tables/cometbft/types/v1beta1/DuplicateVoteEvidence.jsonsource/json_tables/cometbft/types/v1beta1/EvidenceParams.jsonsource/json_tables/cometbft/types/v1beta1/Header.jsonsource/json_tables/cometbft/types/v1beta1/LightClientAttackEvidence.jsonsource/json_tables/cometbft/types/v1beta1/Part.jsonsource/json_tables/cometbft/types/v1beta1/Proposal.jsonsource/json_tables/cometbft/types/v1beta1/SimpleValidator.jsonsource/json_tables/cometbft/types/v1beta1/TxProof.jsonsource/json_tables/cometbft/types/v1beta1/Validator.jsonsource/json_tables/cometbft/types/v1beta1/Vote.jsonsource/json_tables/cometbft/types/v1beta2/ConsensusParams.jsonsource/json_tables/cosmos/Coin.jsonsource/json_tables/cosmos/DecCoin.jsonsource/json_tables/cosmos/DecProto.jsonsource/json_tables/cosmos/IntProto.jsonsource/json_tables/cosmos/Result.jsonsource/json_tables/cosmos/SearchBlocksResult.jsonsource/json_tables/cosmos/TxMsgData.jsonsource/json_tables/cosmos/TxResponse.jsonsource/json_tables/cosmos/auth/BaseAccount.jsonsource/json_tables/cosmos/auth/GenesisState.jsonsource/json_tables/cosmos/auth/QueryAccountResponse.jsonsource/json_tables/cosmos/auth/QueryAccountsRequest.jsonsource/json_tables/cosmos/auth/QueryAccountsResponse.jsonsource/json_tables/cosmos/auth/QueryModuleAccountByNameResponse.jsonsource/json_tables/cosmos/auth/QueryModuleAccountsResponse.jsonsource/json_tables/cosmos/authz/Grant.jsonsource/json_tables/cosmos/authz/GrantAuthorization.jsonsource/json_tables/cosmos/authz/MsgExec.jsonsource/json_tables/cosmos/authz/QueryGranteeGrantsRequest.jsonsource/json_tables/cosmos/authz/QueryGranteeGrantsResponse.jsonsource/json_tables/cosmos/authz/QueryGranterGrantsRequest.jsonsource/json_tables/cosmos/authz/QueryGranterGrantsResponse.jsonsource/json_tables/cosmos/authz/QueryGrantsRequest.jsonsource/json_tables/cosmos/authz/QueryGrantsResponse.jsonsource/json_tables/cosmos/bank/Balance.jsonsource/json_tables/cosmos/bank/BalanceUpdate.jsonsource/json_tables/cosmos/bank/DenomOwner.jsonsource/json_tables/cosmos/bank/GenesisState.jsonsource/json_tables/cosmos/bank/Input.jsonsource/json_tables/cosmos/bank/MsgSend.jsonsource/json_tables/cosmos/bank/Output.jsonsource/json_tables/cosmos/bank/QueryAllBalancesRequest.jsonsource/json_tables/cosmos/bank/QueryAllBalancesResponse.jsonsource/json_tables/cosmos/bank/QueryBalanceResponse.jsonsource/json_tables/cosmos/bank/QueryDenomOwnersByQueryRequest.jsonsource/json_tables/cosmos/bank/QueryDenomOwnersByQueryResponse.jsonsource/json_tables/cosmos/bank/QueryDenomOwnersRequest.jsonsource/json_tables/cosmos/bank/QueryDenomOwnersResponse.jsonsource/json_tables/cosmos/bank/QueryDenomsMetadataRequest.jsonsource/json_tables/cosmos/bank/QueryDenomsMetadataResponse.jsonsource/json_tables/cosmos/bank/QuerySendEnabledRequest.jsonsource/json_tables/cosmos/bank/QuerySendEnabledResponse.jsonsource/json_tables/cosmos/bank/QuerySpendableBalanceByDenomResponse.jsonsource/json_tables/cosmos/bank/QuerySpendableBalancesRequest.jsonsource/json_tables/cosmos/bank/QuerySpendableBalancesResponse.jsonsource/json_tables/cosmos/bank/QuerySupplyOfResponse.jsonsource/json_tables/cosmos/bank/QueryTotalSupplyRequest.jsonsource/json_tables/cosmos/bank/QueryTotalSupplyResponse.jsonsource/json_tables/cosmos/bank/SendAuthorization.jsonsource/json_tables/cosmos/bank/Supply.jsonsource/json_tables/cosmos/circuit/AccountsResponse.jsonsource/json_tables/cosmos/circuit/QueryAccountsRequest.jsonsource/json_tables/cosmos/cmtservice/Block.jsonsource/json_tables/cosmos/cmtservice/GetBlockByHeightResponse.jsonsource/json_tables/cosmos/cmtservice/GetLatestBlockResponse.jsonsource/json_tables/cosmos/cmtservice/GetLatestValidatorSetRequest.jsonsource/json_tables/cosmos/cmtservice/GetLatestValidatorSetResponse.jsonsource/json_tables/cosmos/cmtservice/GetNodeInfoResponse.jsonsource/json_tables/cosmos/cmtservice/GetValidatorSetByHeightRequest.jsonsource/json_tables/cosmos/cmtservice/GetValidatorSetByHeightResponse.jsonsource/json_tables/cosmos/cmtservice/Header.jsonsource/json_tables/cosmos/cmtservice/Validator.jsonsource/json_tables/cosmos/consensus/MsgUpdateParams.jsonsource/json_tables/cosmos/consensus/QueryParamsResponse.jsonsource/json_tables/cosmos/crisis/GenesisState.jsonsource/json_tables/cosmos/crisis/MsgUpdateParams.jsonsource/json_tables/cosmos/distribution/CommunityPoolSpendProposal.jsonsource/json_tables/cosmos/distribution/DelegationDelegatorReward.jsonsource/json_tables/cosmos/distribution/DelegatorStartingInfo.jsonsource/json_tables/cosmos/distribution/FeePool.jsonsource/json_tables/cosmos/distribution/MsgCommunityPoolSpend.jsonsource/json_tables/cosmos/distribution/MsgDepositValidatorRewardsPool.jsonsource/json_tables/cosmos/distribution/MsgFundCommunityPool.jsonsource/json_tables/cosmos/distribution/MsgWithdrawDelegatorRewardResponse.jsonsource/json_tables/cosmos/distribution/MsgWithdrawValidatorCommissionResponse.jsonsource/json_tables/cosmos/distribution/Params.jsonsource/json_tables/cosmos/distribution/QueryCommunityPoolResponse.jsonsource/json_tables/cosmos/distribution/QueryDelegationRewardsResponse.jsonsource/json_tables/cosmos/distribution/QueryDelegationTotalRewardsResponse.jsonsource/json_tables/cosmos/distribution/QueryValidatorDistributionInfoResponse.jsonsource/json_tables/cosmos/distribution/QueryValidatorSlashesRequest.jsonsource/json_tables/cosmos/distribution/QueryValidatorSlashesResponse.jsonsource/json_tables/cosmos/distribution/ValidatorAccumulatedCommission.jsonsource/json_tables/cosmos/distribution/ValidatorCurrentRewards.jsonsource/json_tables/cosmos/distribution/ValidatorHistoricalRewards.jsonsource/json_tables/cosmos/distribution/ValidatorOutstandingRewards.jsonsource/json_tables/cosmos/distribution/ValidatorOutstandingRewardsRecord.jsonsource/json_tables/cosmos/distribution/ValidatorSlashEvent.jsonsource/json_tables/cosmos/evidence/Equivocation.jsonsource/json_tables/cosmos/evidence/GenesisState.jsonsource/json_tables/cosmos/evidence/MsgSubmitEvidence.jsonsource/json_tables/cosmos/evidence/QueryAllEvidenceRequest.json
Comment on lines
+2
to
+23
| COSMOS_SDK_VERSION := v0.50.14-inj.9 | ||
| COSMOS_SDK_REPO := https://github.com/InjectiveLabs/cosmos-sdk.git | ||
|
|
||
| INJECTIVE_CORE_VERSION := v1.18.0 | ||
| INJECTIVE_CORE_VERSION := v1.19.0 | ||
| INJECTIVE_CORE_REPO := https://github.com/InjectiveLabs/injective-core.git | ||
|
|
||
| INDEXER_VERSION := v1.18.3 | ||
| INDEXER_VERSION := v1.19.0 | ||
| INDEXER_REPO := https://github.com/InjectiveLabs/injective-indexer.git | ||
|
|
||
| IBC_GO_VERSION := v8.7.0-inj.3 | ||
| IBC_GO_VERSION := v8.7.0-inj.4 | ||
| IBC_GO_REPO := https://github.com/InjectiveLabs/ibc-go.git | ||
|
|
||
| COMETBFT_VERSION := v1.0.1-inj.6 | ||
| COMETBFT_VERSION := v1.0.1-inj.7 | ||
| COMETBFT_REPO := https://github.com/InjectiveLabs/cometbft.git | ||
|
|
||
| WASMD_VERSION := v0.53.3-inj.2 | ||
| WASMD_VERSION := v0.53.3-inj.3 | ||
| WASMD_REPO := https://github.com/InjectiveLabs/wasmd.git | ||
|
|
||
| PYTHON_SDK_VERSION := v1.13.0 | ||
| PYTHON_SDK_VERSION := v1.14.0 | ||
| PYTHON_SDK_REPO := https://github.com/InjectiveLabs/sdk-python.git | ||
|
|
||
| GO_SDK_VERSION := v1.60.0 | ||
| GO_SDK_VERSION := v1.61.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify all dependency version tags exist in their repositories
echo "Checking version tags..."
# Array of repo URLs and versions
declare -A repos=(
["https://github.com/InjectiveLabs/cosmos-sdk.git"]="v0.50.14-inj.9"
["https://github.com/InjectiveLabs/injective-core.git"]="v1.19.0"
["https://github.com/InjectiveLabs/injective-indexer.git"]="v1.19.0"
["https://github.com/InjectiveLabs/ibc-go.git"]="v8.7.0-inj.4"
["https://github.com/InjectiveLabs/cometbft.git"]="v1.0.1-inj.7"
["https://github.com/InjectiveLabs/wasmd.git"]="v0.53.3-inj.3"
["https://github.com/InjectiveLabs/sdk-python.git"]="v1.14.0"
["https://github.com/InjectiveLabs/sdk-go.git"]="v1.61.0"
)
failed=0
for repo in "${!repos[@]}"; do
version="${repos[$repo]}"
echo "Checking $repo for tag $version..."
if git ls-remote --tags "$repo" | grep -q "refs/tags/$version"; then
echo "✓ Found $version in $repo"
else
echo "✗ Tag $version NOT FOUND in $repo"
failed=1
fi
done
if [ $failed -eq 1 ]; then
echo ""
echo "ERROR: Some version tags were not found. Please verify the version numbers."
exit 1
else
echo ""
echo "SUCCESS: All version tags exist in their repositories."
fiRepository: InjectiveLabs/api-exchange-docs
Length of output: 1622
🏁 Script executed:
#!/bin/bash
# Check if the injective-core and injective-indexer repos are accessible via GitHub API
# and verify the exact repository status
echo "Checking repository accessibility via GitHub API..."
echo ""
# Function to check repo using curl to GitHub API
check_github_repo() {
local repo_path=$1
echo "Checking: $repo_path"
# Try GitHub API endpoint
status=$(curl -s -o /dev/null -w "%{http_code}" "https://api.github.com/repos/$repo_path")
if [ "$status" = "200" ]; then
echo "✓ Repository exists and is public"
# Get latest releases/tags
curl -s "https://api.github.com/repos/$repo_path/tags?per_page=5" | head -c 200
echo ""
elif [ "$status" = "404" ]; then
echo "✗ Repository not found (404)"
elif [ "$status" = "403" ]; then
echo "⚠ Access forbidden (403) - may be private"
else
echo "⚠ Status: $status"
fi
echo ""
}
check_github_repo "InjectiveLabs/injective-core"
check_github_repo "InjectiveLabs/injective-indexer"
# Also check the Makefile to see if there's any additional context
echo "Checking Makefile for context..."
if [ -f "Makefile" ]; then
echo "Makefile found. Checking relevant lines..."
head -25 Makefile
fiRepository: InjectiveLabs/api-exchange-docs
Length of output: 1151
Two dependency repositories do not exist on GitHub and will cause build failures.
Verification of dependency version tags reveals a critical issue: the repositories for injective-core (v1.19.0) and injective-indexer (v1.19.0) return 404 Not Found errors and cannot be accessed. The following six repositories were successfully verified:
- cosmos-sdk: v0.50.14-inj.9 ✓
- ibc-go: v8.7.0-inj.4 ✓
- wasmd: v0.53.3-inj.3 ✓
- sdk-python: v1.14.0 ✓
- sdk-go: v1.61.0 ✓
- cometbft: v1.0.1-inj.7 ✓
Correct the URLs for INJECTIVE_CORE_REPO and INDEXER_REPO or verify if these repositories have been renamed or moved to a different organization.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Makefile` around lines 2 - 23, INJECTIVE_CORE_REPO and INDEXER_REPO point to
non-existent GitHub URLs and will break the build; locate the correct
repositories or organization (or their new names) and update the Makefile
variables INJECTIVE_CORE_REPO and INDEXER_REPO to the valid GitHub repository
URLs, and if the tags v1.19.0 don't exist there also update
INJECTIVE_CORE_VERSION and INDEXER_VERSION to the correct tags (or remove
pinning), then re-run a git/tag check to ensure the URLs and versions resolve
successfully.
Comment on lines
+450
to
457
| elif compgen -G "$module_dir/*.pb.go" > /dev/null 2>&1; then | ||
| echo "Processing module with direct .pb.go files: $module_name" | ||
| mkdir -p "$output_dir/$module_name" | ||
| process_directory "$module_dir" "$output_dir/$module_name" | ||
| elif find "$module_dir" -name "*.pb.go" -type f | head -1 | grep -q .; then | ||
| echo "Processing namespace directory: $module_name" | ||
| process_repository_modules "$module_dir" "$output_dir/$module_name" | ||
| fi |
There was a problem hiding this comment.
Module traversal can miss files due branch structure and brittle pipeline.
Two issues in this block:
elifmakes direct-file modules skip deeper namespace traversal, so nested.pb.gofiles in the same module are not processed.find ... | head -1 | grep -q .is fragile withset -o pipefail.
🔧 Proposed fix
- elif compgen -G "$module_dir/*.pb.go" > /dev/null 2>&1; then
- echo "Processing module with direct .pb.go files: $module_name"
- mkdir -p "$output_dir/$module_name"
- process_directory "$module_dir" "$output_dir/$module_name"
- elif find "$module_dir" -name "*.pb.go" -type f | head -1 | grep -q .; then
- echo "Processing namespace directory: $module_name"
- process_repository_modules "$module_dir" "$output_dir/$module_name"
+ elif compgen -G "$module_dir/*.pb.go" > /dev/null 2>&1; then
+ echo "Processing module with direct .pb.go files: $module_name"
+ mkdir -p "$output_dir/$module_name"
+ process_directory "$module_dir" "$output_dir/$module_name"
+ if find "$module_dir" -mindepth 2 -type f -name "*.pb.go" -print -quit | grep -q .; then
+ echo "Processing namespace directory: $module_name"
+ process_repository_modules "$module_dir" "$output_dir/$module_name"
+ fi
+ elif find "$module_dir" -type f -name "*.pb.go" -print -quit | grep -q .; then
+ echo "Processing namespace directory: $module_name"
+ process_repository_modules "$module_dir" "$output_dir/$module_name"
fi📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| elif compgen -G "$module_dir/*.pb.go" > /dev/null 2>&1; then | |
| echo "Processing module with direct .pb.go files: $module_name" | |
| mkdir -p "$output_dir/$module_name" | |
| process_directory "$module_dir" "$output_dir/$module_name" | |
| elif find "$module_dir" -name "*.pb.go" -type f | head -1 | grep -q .; then | |
| echo "Processing namespace directory: $module_name" | |
| process_repository_modules "$module_dir" "$output_dir/$module_name" | |
| fi | |
| elif compgen -G "$module_dir/*.pb.go" > /dev/null 2>&1; then | |
| echo "Processing module with direct .pb.go files: $module_name" | |
| mkdir -p "$output_dir/$module_name" | |
| process_directory "$module_dir" "$output_dir/$module_name" | |
| if find "$module_dir" -mindepth 2 -type f -name "*.pb.go" -print -quit | grep -q .; then | |
| echo "Processing namespace directory: $module_name" | |
| process_repository_modules "$module_dir" "$output_dir/$module_name" | |
| fi | |
| elif find "$module_dir" -type f -name "*.pb.go" -print -quit | grep -q .; then | |
| echo "Processing namespace directory: $module_name" | |
| process_repository_modules "$module_dir" "$output_dir/$module_name" | |
| fi |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@scripts/generate_proto_json_files.sh` around lines 450 - 457, The branch
logic can skip nested .pb.go files and the find pipeline is fragile; modify the
conditionals so you do not use an elif that prevents both checks — e.g., first
check for any .pb.go anywhere under module_dir using find with -print -quit and
test its exit status (avoid piping to head/grep), and separately check for
direct files with compgen to call process_directory for root-level .pb.go and
process_repository_modules for nested/namespace modules (or run both paths as
appropriate); update the find invocation to use "find \"$module_dir\" -name
\"*.pb.go\" -type f -print -quit" and use its exit code to decide calling
process_repository_modules, while keeping process_directory invocation for
direct matches (functions: process_directory, process_repository_modules;
variable: module_dir, module_name).
|
|
||
| <!-- MARKDOWN-AUTO-DOCS:START (JSON_TO_HTML_TABLE:src=./source/json_tables/cosmos/tx/BroadcastTxResponse.json) --> | ||
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">tx_response</td><td class="type-td td_text">types.TxResponse</td><td class="description-td td_text">tx_response is the queried TxResponses.</td></tr></tbody></table> | ||
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">tx_response</td><td class="type-td td_text">TxResponse</td><td class="description-td td_text">tx_response is the queried TxResponses.</td></tr></tbody></table> |
There was a problem hiding this comment.
Fix singular/plural mismatch in tx_response description.
The description says “queried TxResponses” while the field is singular (tx_response). Please make this singular for consistency and clarity.
✏️ Proposed wording update
- ... <td class="description-td td_text">tx_response is the queried TxResponses.</td> ...
+ ... <td class="description-td td_text">tx_response is the queried TxResponse.</td> ...Also applies to: 447-447, 694-694, 941-941, 1204-1204, 2130-2130
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@source/includes/_account.md` at line 208, Update the parameter description
for tx_response to use singular phrasing: replace "tx_response is the queried
TxResponses." with "tx_response is the queried TxResponse." and apply the same
singular fix for every other occurrence where the tx_response parameter
description currently uses "queried TxResponses" so all descriptions for the
tx_response parameter are consistent and singular.
| <tr ><td class="parameter-td td_text">cumulative_funding_entry</td><td class="type-td td_text">string</td><td class="description-td td_text">Cumulative funding entry of the position</td></tr> | ||
| <tr ><td class="parameter-td td_text">effective_cumulative_funding_entry</td><td class="type-td td_text">string</td><td class="description-td td_text">Effective cumulative funding entry of the position</td></tr></tbody></table> | ||
| <tr ><td class="parameter-td td_text">effective_cumulative_funding_entry</td><td class="type-td td_text">string</td><td class="description-td td_text">Effective cumulative funding entry of the position</td></tr> | ||
| <tr ><td class="parameter-td td_text">upnl</td><td class="type-td td_text">string</td><td class="description-td td_text">Unrealized profit and loss of the position (only present when requested with with_upnl=true)</td></tr></tbody></table> |
There was a problem hiding this comment.
Fix duplicated wording in upnl description.
The phrase “with with_upnl=true” has a typo and should be corrected in both places.
✏️ Proposed docs fix
-<tr ><td class="parameter-td td_text">upnl</td><td class="type-td td_text">string</td><td class="description-td td_text">Unrealized profit and loss of the position (only present when requested with with_upnl=true)</td></tr></tbody></table>
+<tr ><td class="parameter-td td_text">upnl</td><td class="type-td td_text">string</td><td class="description-td td_text">Unrealized profit and loss of the position (only present when requested with `with_upnl=true`)</td></tr></tbody></table>Also applies to: 2773-2773
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@source/includes/_derivativesrpc.md` at line 2528, The upnl field description
contains a duplicated word "with with_upnl=true"; update the description for the
parameter named "upnl" in source/includes/_derivativesrpc.md to remove the
duplicate and use correct phrasing (e.g., "only present when requested with
upnl=true" or "only present when with_upnl=true" consistently), and fix the same
duplicated wording at the other occurrence mentioned (the second "upnl"
description around the later occurrence). Ensure both occurrences reference the
same, corrected form.
Comment on lines
+122
to
+124
| ``` json | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Add concrete response payload examples for new endpoints.
These newly added sections currently show empty response example blocks, which makes integration validation harder for users.
Also applies to: 269-271, 890-892
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@source/includes/_insurance.md` around lines 122 - 124, There are empty
response example JSON blocks in source/includes/_insurance.md (notably the three
empty ```json``` blocks around the new endpoint sections); replace each empty
block with concrete sample response payloads that match the endpoint schemas
(include typical fields, data types, nested objects/arrays, and an example of
success and common error response where relevant), locating the blocks by
looking for the empty triple-backtick json fences under the new endpoint
headings in that file and updating them with realistic example JSON bodies that
consumers can use for integration testing.
| <!-- MARKDOWN-AUTO-DOCS:END --> | ||
|
|
||
|
|
||
| ## StreamPricesByMarket |
There was a problem hiding this comment.
Section name is inconsistent with method naming.
Line 697 uses StreamPricesByMarket (singular), while the request file and examples use StreamPricesByMarkets (plural). Aligning names will avoid confusion.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@source/includes/_oraclerpc.md` at line 697, Heading "StreamPricesByMarket" is
inconsistent with the RPC/method name used elsewhere; change the section title
to "StreamPricesByMarkets" so it matches the request file and examples, and
update any in-page references or links that point to the old singular name (look
for occurrences of StreamPricesByMarket and replace them with
StreamPricesByMarkets).
|
|
||
| <!-- MARKDOWN-AUTO-DOCS:START (JSON_TO_HTML_TABLE:src=./source/json_tables/cosmos/cmtservice/GetLatestValidatorSetRequest.json) --> | ||
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th><th class="required-th">Required</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">pagination</td><td class="type-td td_text">query.PageRequest</td><td class="description-td td_text">pagination defines an pagination for the request.</td><td class="required-td td_text">No</td></tr></tbody></table> | ||
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th><th class="required-th">Required</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">pagination</td><td class="type-td td_text">PageRequest</td><td class="description-td td_text">pagination defines an pagination for the request.</td><td class="required-td td_text">No</td></tr></tbody></table> |
There was a problem hiding this comment.
Fix grammar in pagination descriptions.
The phrase “defines an pagination” should be “defines a pagination” in these rows.
✏️ Proposed wording update
- pagination defines an pagination for the request.
+ pagination defines a pagination for the request.
- pagination defines an pagination for the response.
+ pagination defines a pagination for the response.Also applies to: 1338-1338, 1480-1480, 1550-1550
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@source/includes/_tendermint.md` at line 1268, Update the pagination
description text in source/includes/_tendermint.md: replace the incorrect phrase
"defines an pagination for the request." with "defines a pagination for the
request." for the table entry where the Parameter is "pagination" (and likewise
fix the same phrase in the other occurrences referenced around the file, e.g.,
the rows at the other instances noted); ensure the exact wording change is
applied to each table cell containing "defines an pagination" so all occurrences
are corrected.
|
|
||
| <!-- MARKDOWN-AUTO-DOCS:START (JSON_TO_HTML_TABLE:src=./source/json_tables/injective/tokenfactory/Params.json) --> | ||
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">denom_creation_fee</td><td class="type-td td_text">github_com_cosmos_cosmos_sdk_types.Coins</td><td class="description-td td_text">The denom creation fee</td></tr></tbody></table> | ||
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">denom_creation_fee</td><td class="type-td td_text">Coins</td><td class="description-td td_text">The denom creation fee</td></tr></tbody></table> |
There was a problem hiding this comment.
Use a consistent coin type name in this section.
Line 578 uses Coins, while the nearby type block is documented as Coin (Line 583). This can confuse readers about whether this is a distinct type or an array alias. Consider changing to Coin array (or adding a dedicated Coins type block) for consistency.
💡 Suggested doc fix
-<tr ><td class="parameter-td td_text">denom_creation_fee</td><td class="type-td td_text">Coins</td><td class="description-td td_text">The denom creation fee</td></tr>
+<tr ><td class="parameter-td td_text">denom_creation_fee</td><td class="type-td td_text">Coin array</td><td class="description-td td_text">The denom creation fee</td></tr>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">denom_creation_fee</td><td class="type-td td_text">Coins</td><td class="description-td td_text">The denom creation fee</td></tr></tbody></table> | |
| <table class="JSON-TO-HTML-TABLE"><thead><tr><th class="parameter-th">Parameter</th><th class="type-th">Type</th><th class="description-th">Description</th></tr></thead><tbody ><tr ><td class="parameter-td td_text">denom_creation_fee</td><td class="type-td td_text">Coin array</td><td class="description-td td_text">The denom creation fee</td></tr></tbody></table> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@source/includes/_tokenfactory.md` at line 578, The parameter docs for
denom_creation_fee use an inconsistent type name ("Coins") while nearby
documentation uses "Coin"; update the denom_creation_fee type to a consistent
representation — either change "Coins" to "Coin array" in the parameter table
for denom_creation_fee, or add a dedicated "Coins" type block that documents it
as an array alias; ensure references to denom_creation_fee and the Coin/Coin
array naming are consistent across this section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit