Skip to content

feat:add minio #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
InftyAI-Agent merged 1 commit into from
Nov 11, 2024
Merged

feat:add minio #13

InftyAI-Agent merged 1 commit into from
Nov 11, 2024

Conversation

@qinguoyi
Copy link
Member

@qinguoyi qinguoyi commented Oct 23, 2024

What this PR does / why we need it

#4

Add support minio

Which issue(s) this PR fixes

None

Special notes for your reviewer

this pr, it mainly includes things：

  1. support minio storage
  2. add minio integration-ut
  3. update docs
image

Does this PR introduce a user-facing change?

Add support for minio

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Oct 23, 2024
@qinguoyi qinguoyi mentioned this pull request Oct 23, 2024
Closed
@kerthcet
Copy link
Member

kerthcet commented Oct 29, 2024

Thanks for the PR, I may take more time to review this, I guess tomorrow. Sorry for that.

@qinguoyi
Copy link
Member Author

qinguoyi commented Oct 29, 2024

That’s okay, there's no rush.

@kerthcet
Copy link
Member

kerthcet commented Nov 6, 2024

Updates:
I'm busy with the kubernetes review work, we're approaching the code freeze, so this maybe later until this weekend. Sorry for that, but I promise it will be finished this week.

@kerthcet
Copy link
Member

kerthcet commented Nov 11, 2024

/kind cleanup
/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Nov 11, 2024
@InftyAI-Agent InftyAI-Agent merged commit eb05e61 into InftyAI:main Nov 11, 2024
@kerthcet
Copy link
Member

kerthcet commented Nov 11, 2024

I'll test with AWS s3 to see whether fits as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qinguoyi @kerthcet @InftyAI-Agent