Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
approvers:
- dalphyx
- kerthcet

reviewers:
- dalphyx
- kerthcet
7 changes: 4 additions & 3 deletions tests/unit/experiment/test_craft_exp.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ async def fake_work(trial: Trial):
async def test_create_experiment_with_run():
init(project_id=uuid.uuid4(), artifact_insecure=True, init_tables=True)

async def fake_work(cancel_func: callable):
async def fake_work(cancel_func: callable, trial_id: uuid.UUID):
assert current_trial_id.get() == trial_id
await asyncio.sleep(3)
cancel_func()

Expand All @@ -148,10 +149,10 @@ async def fake_work(cancel_func: callable):
):
start_time = datetime.now()

trial.start_run(lambda: fake_work(trial.done))
trial.start_run(lambda: fake_work(trial.done, trial.id))
assert len(trial._runs) == 1

trial.start_run(lambda: fake_work(trial.done))
trial.start_run(lambda: fake_work(trial.done, trial.id))
assert len(trial._runs) == 2

await trial.wait()
Expand Down
Loading