Skip to content

Conversation

@akhilmhdh
Copy link
Member

Description 📣

This PR adds the e2ee to the github pipeline. This also fixes issues that are happening when running e2ee test on GitHub environment.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh requested a review from varonix0 January 20, 2026 19:23
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Summary

This PR adds e2ee tests to the GitHub Actions pipeline by creating a new workflow and updating test infrastructure to work in CI environments.

Key Changes:

  • New run-cli-e2e-tests.yml workflow that builds CLI and runs e2e tests on every PR
  • Updated Docker compose wait strategy from listening port to HTTP health check (/api/status) with increased timeout
  • Changed encryption key format and switched default Dockerfile from Dockerfile.dev.fips to standard Dockerfile
  • Fixed expected log messages in tests to match actual CLI output

Issues Found:

  • Invalid Go version 1.25.2 specified in workflow (doesn't exist)
  • Test path github.com/infisical/cli/e2e-tests/... doesn't match the actual module name

Confidence Score: 2/5

  • This PR has critical configuration errors that will prevent the workflow from running successfully
  • Two critical issues will cause workflow failure: invalid Go version (1.25.2 doesn't exist) and incorrect test path. These must be fixed before the workflow can run. The other changes are reasonable improvements to test infrastructure.
  • .github/workflows/run-cli-e2e-tests.yml requires immediate fixes to Go version and test path before this workflow can execute successfully

Important Files Changed

Filename Overview
.github/workflows/run-cli-e2e-tests.yml New workflow to run e2ee tests; uses invalid Go version 1.25.2 (not released), test path may be incorrect
.github/workflows/release_build_infisical_cli.yml Added cli-tests job as dependency for release jobs; straightforward workflow orchestration change
e2e/packages/infisical/compose.go Updated health check strategy and encryption key format; port configuration more explicit
e2e/relay/gateway_test.go Updated expected log message string to match actual CLI output

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@varonix0 varonix0 merged commit 8ef3a3c into main Jan 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants