fix: Optimize autograd backward tensor lifetime#149
Open
Chamberlain0w0 wants to merge 1 commit intomasterfrom
Open
fix: Optimize autograd backward tensor lifetime#149Chamberlain0w0 wants to merge 1 commit intomasterfrom
Chamberlain0w0 wants to merge 1 commit intomasterfrom
Conversation
chen2021673
reviewed
May 8, 2026
| // layers. PyTorch's non-recursive engine does not have that stack | ||
| // retention pattern, so flush AccumulateGrad edges before recursing | ||
| // into non-leaf activation edges. | ||
| for (size_t idx = 0; idx < grad_inputs.size(); ++idx) { |
Contributor
There was a problem hiding this comment.
这里要遍历两次吗?如果后续希望实现更接近 PyTorch 的 queue-based autograd engine,要不要现在直接放一个用于排序 next_functions_ 的函数,之后可以继续完善这个函数的逻辑
Contributor
Author
There was a problem hiding this comment.
感觉目前的状况不太好弄,主要 grad_inputs[idx] 和 next_functions_[idx] 是按 input index 对齐的,而 input index 又跟 module/模型构造有关,如果这要改的话就得一连串地改,只改这一处的话会对不上位置。
如果要排序的话,最多也就是额外再维护一个 list(而不是原地修改 next_functions_),根据这个规则重排得到一个新的顺序,然后再遍历一次。但其实目前 grad_inputs 最多也就两三个,遍历两次也不会有很大开销。
JYMiracle305
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
优化 autograd backward 流程中对于 leaf 参数梯度的释放时机,降低训练过程的峰值显存占用。
设计文档详见:https://gxtctab8no8.feishu.cn/wiki/SJBKwmoCRiRQpAkAygmcXt0UnCd?from=from_copylink