ci: add ci_test workflows and fix NVIDIA probing#590
Draft
zhangyue207 wants to merge 14 commits intomasterfrom
Draft
ci: add ci_test workflows and fix NVIDIA probing#590zhangyue207 wants to merge 14 commits intomasterfrom
zhangyue207 wants to merge 14 commits intomasterfrom
Conversation
f6909f0 to
eacc238
Compare
eacc238 to
656626d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci_testCI work intomaster..ciimplementation with the externalInfiniTensor/cisubmodule..github/workflows/ci_test.ymland.github/ci_config.yamlas the parent GitHub Actions entrypoint/config.--devices nvidia.tests/conftest.pyrespect explicit--devicesplatform selections before falling back to the historical broad torch-device mapping.Motivation
This PR brings the
ci_testworkflow work intomasterand fixes the NVIDIA validation failure found while testing that workflow locally.The NVIDIA job crashed because
device=cudawas treated as all CUDA-like InfiniOps platforms:nvidia,metax, andiluvatar. On an NVIDIA runner,skip_op_without_platform_implcould still query MetaX / Iluvatar implementation indices, which may abort in native code instead of producing a safe pytest skip.Closes: N/A.
Type of Change
fix— bug fixbuild/ci— build system or CI configurationPlatforms Affected
WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)Test Results on Supported Platforms
pytestResult3758 passed, 1363 skippedpython3 .ci/run.py --config .github/ci_config.yaml --job nvidia_gpu --gpu-id 0 --local.Benchmark / Performance Impact
N/A — this PR only changes CI/test platform selection behavior.
Notes for Reviewers
This PR is now targeted at
master, so it includes the originalci_testbranch changes plus the follow-up NVIDIA probing fix.Review focus:
.cisubmodule migration and.githubworkflow/config boundary.--devices nvidia,device=cudaonly queriesnvidiaimplementation indices.--devices, the historical broad fallback remains unchanged.Checklist
<type>/xxx-yyyy-zzzz. Existing branch iscodex/fix-nvidia-platform-probing.fixup!/squash!/wipcommits remain.ci_testCI intomasterand fixing the NVIDIA CI failure.ruff check tests/conftest.pypasses.ruff format --check tests/conftest.pypasses.python3 -m py_compile tests/conftest.pypasses.python3 .ci/config_to_matrix.py --config .github/ci_config.yaml --dump-by-type.pytestwas run locally on every supported platform this PR can affect. NVIDIA was run locally; other hardware was not available.