Open
Conversation
bitzyz
commented
Mar 12, 2026
bitzyz
commented
- ✅Modified data_type.h to use WITH_CAMBRICON && CNNL_H_ condition
- ✅ Added rmsnorm cambricon op in src/cambricon/rms_norm
- ✅ Modified CMakeLists.txt to correctly handle .mlu files (using cncc compiler)
- ✅ Added definition for NRAM_MAX_SIZE
- ✅ Added definition for sumInternal function
- ✅ Used BANG macro for conditional compilation of MLU-specific code
- ✅ Fixed member initialization order in base/rms_norm.h
- ✅ Moved cambricon/common.h to common/cambricon/common.h
bitzyz
force-pushed
the
feat/dev-rmsnorm-cambricon
branch
2 times, most recently
from
8c13177 to
7655800
Compare
bitzyz
force-pushed
the
feat/dev-rmsnorm-cambricon
branch
from
7655800 to
35e2a2a
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.