Skip to content

Conversation

@NikhitaR-IFX
Copy link
Member

@NikhitaR-IFX NikhitaR-IFX commented Aug 22, 2025

Summary

  • Extending from extmod/modbluetooth.c build fine on providing empty function implementations.
  • These might not be already full list of functions needed but atleast required ones.

@github-actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@NikhitaR-IFX NikhitaR-IFX marked this pull request as draft August 22, 2025 07:50
@NikhitaR-IFX NikhitaR-IFX marked this pull request as ready for review August 25, 2025 12:00

MPY_CROSS_FLAGS += -march=armv7m

ifeq ($(MICROPY_PY_BLUETOOTH),1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this belong to the mtb-psoc6-libs?
That module is in charge of handling this file and generating the sources. Is that of any concern of the mpy side?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, the CI is failing 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh the CI failing is I should update the exp file now. I will fix that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this belong to the mtb-psoc6-libs? That module is in charge of handling this file and generating the sources. Is that of any concern of the mpy side?

In mtb-psoc6-libs/makefile_mtb.mk, I did not find any inclusions from micropython/ports/psoc6 path. I was believing if that needed to be consistent henceforth as well and moved the ble target to location where it is now. I think other way should also work, if it is ok to include vice versa?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am referring to the .bt file. Micropython should not need to know about it. Replied in the mtb-integration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now

@NikhitaR-IFX
Copy link
Member Author

The time_pulse test is failing but should not ideally be anything impacted from changes in this PR. I suggest we ignore this for now and when en-ble branch is merged to ports-psoc6-main, we can check and fix (if needed any). Does that work?

@jaenrig-ifx
Copy link
Member

The time_pulse test is failing but should not ideally be anything impacted from changes in this PR. I suggest we ignore this for now and when en-ble branch is merged to ports-psoc6-main, we can check and fix (if needed any). Does that work?

Yes please. If there is not evident effect about this changes, we make sure later when merging against the main. Also I think if you rebase "ports-psoc6-main" into "en-ble" that might be "fixed".

@NikhitaR-IFX
Copy link
Member Author

The time_pulse test is failing but should not ideally be anything impacted from changes in this PR. I suggest we ignore this for now and when en-ble branch is merged to ports-psoc6-main, we can check and fix (if needed any). Does that work?

Yes please. If there is not evident effect about this changes, we make sure later when merging against the main. Also I think if you rebase "ports-psoc6-main" into "en-ble" that might be "fixed".

Yes I will do that too

Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
@NikhitaR-IFX NikhitaR-IFX merged commit 64c5aa5 into en-ble Aug 26, 2025
33 of 37 checks passed
@NikhitaR-IFX NikhitaR-IFX deleted the en-extmod-ble branch August 26, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants