Skip to content

Conversation

@ramya-subramanyam
Copy link
Contributor

Description of Change

  • Refactor code check workflow to be more generic and not depend on particular results.
  • The report needs to be generated irrespective of which results are available cppcheck or clang-tidy or none.
  • Added generate report as a wrapper script which can be called from workflow/ locally to handle the same.

@ramya-subramanyam ramya-subramanyam marked this pull request as draft April 15, 2025 03:51
@ederjc ederjc removed their request for review April 15, 2025 06:31

# Check if cppcheck results exist
if [ -d "${RESULTS_DIR}/cppcheck" ]; then
CPP_CHECK_REPORT_XML="${RESULTS_DIR}/cppcheck/check-cppcheck/check-cppcheck-errors.xml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed yesterday, please remove any dependencies to specific clang-tidy and cppcheck check names (check-clang-tidy*, ....).
The directory name below $(RESULTS_DIR) will remain the actual tool name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ramya-subramanyam ramya-subramanyam force-pushed the refactor-html-report-generation branch from 3048ffd to 67f06b4 Compare May 7, 2025 06:21
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
@ramya-subramanyam ramya-subramanyam force-pushed the refactor-html-report-generation branch from 67f06b4 to cb1fd6a Compare May 7, 2025 06:24
@ramya-subramanyam ramya-subramanyam force-pushed the refactor-html-report-generation branch from 775c7a4 to ba812b2 Compare June 3, 2025 03:30
@ramya-subramanyam ramya-subramanyam force-pushed the refactor-html-report-generation branch 2 times, most recently from 3b231d5 to 05607e3 Compare June 10, 2025 02:40
@ramya-subramanyam ramya-subramanyam force-pushed the refactor-html-report-generation branch from 05607e3 to 7a0166e Compare June 10, 2025 03:58
@ramya-subramanyam ramya-subramanyam marked this pull request as ready for review June 11, 2025 05:27
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
@ramya-subramanyam ramya-subramanyam deleted the refactor-html-report-generation branch July 11, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants