Skip to content

Launch fast scaling/upgrading when having primary-replicas and purgeKeysOnRebalance is active #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertompe merged 1 commit into from
Feb 27, 2026
Merged

Launch fast scaling/upgrading when having primary-replicas and purgeKeysOnRebalance is active #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions controllers/redis_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ func (r *RedkeyClusterReconciler) doFastUpgrade(ctx context.Context, redkeyClust

return true, nil
default:
// Fast upgrade start: If purgeKeysOnRebalance property is set to 'true' and we have no primaries. No need to iterate over the partitions.
// If fast upgrade is not allowed but we have no primaries, the cluster must be scaled up adding one extra
// node to be able to move slots and keys in order to ensure keys are preserved.
if redkeyCluster.Spec.PurgeKeysOnRebalance != nil && *redkeyCluster.Spec.PurgeKeysOnRebalance && redkeyCluster.Spec.ReplicasPerPrimary == 0 {
// Fast upgrade start: If purgeKeysOnRebalance property is set to 'true'. No need to iterate over the partitions.
// If fast upgrade is not allowed, the cluster must be scaled up adding one extra node to be able to move slots
// and keys in order to ensure keys are preserved.
if redkeyCluster.Spec.PurgeKeysOnRebalance != nil && *redkeyCluster.Spec.PurgeKeysOnRebalance {
r.logInfo(redkeyCluster.NamespacedName(), "Fast upgrade will be performed")

err := r.updateClusterSubStatus(ctx, redkeyCluster, redkeyv1.SubstatusFastUpgrading, "")
Expand Down Expand Up @@ -800,8 +800,8 @@ func (r *RedkeyClusterReconciler) doFastScaling(ctx context.Context, redkeyClust

return true, nil
default:
// Fast scaling start: If purgeKeysOnRebalance property is set to 'true' and we have no replicasPerPrimary set. No need to iterate over the partitions.
if redkeyCluster.Spec.PurgeKeysOnRebalance != nil && *redkeyCluster.Spec.PurgeKeysOnRebalance && redkeyCluster.Spec.ReplicasPerPrimary == 0 {
// Fast scaling start: If purgeKeysOnRebalance property is set to 'true'. No need to iterate over the partitions.
if redkeyCluster.Spec.PurgeKeysOnRebalance != nil && *redkeyCluster.Spec.PurgeKeysOnRebalance {
r.logInfo(redkeyCluster.NamespacedName(), "Fast upgrading will be performed")

err := r.updateClusterSubStatus(ctx, redkeyCluster, redkeyv1.SubstatusFastScaling, "")
Expand Down
Loading