Skip to content

[DEV-13109] Fix nodegroup logic #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emuzykin1 merged 1 commit into from
Feb 24, 2025
Merged

[DEV-13109] Fix nodegroup logic #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 47 additions & 45 deletions nodes.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,39 +85,39 @@ locals {

insights_default_node_groups = {
general = {
type = "cpu"
spot = false
instance_types = ["m5a.xlarge"]
min_size = 1
max_size = 5
desired_capacity = "3"
type = "cpu"
spot = false
instance_types = ["m5a.xlarge"]
min_size = 1
max_size = 5
desired_capacity = "3"
},
pgo-workers = {
type = "cpu"
spot = false
instance_types = ["m5a.large"]
min_size = 1
max_size = 2
desired_capacity = "2"
taints = "--register-with-taints=indico.io/crunchy=true:NoSchedule"
type = "cpu"
spot = false
instance_types = ["m5a.large"]
min_size = 1
max_size = 2
desired_capacity = "2"
taints = "--register-with-taints=indico.io/crunchy=true:NoSchedule"
},
celery-workers = {
type = "cpu"
spot = false
instance_types = ["m5a.xlarge"]
min_size = 1
max_size = 3
desired_capacity = "1"
taints = "--register-with-taints=indico.io/celery-workers=true:NoSchedule"
type = "cpu"
spot = false
instance_types = ["m5a.xlarge"]
min_size = 1
max_size = 3
desired_capacity = "1"
taints = "--register-with-taints=indico.io/celery-workers=true:NoSchedule"
},
minio = {
type = "cpu"
spot = false
instance_types = ["t3a.xlarge"]
min_size = 1
max_size = 4
desired_capacity = "4"
taints = "--register-with-taints=indico.io/minio=true:NoSchedule"
type = "cpu"
spot = false
instance_types = ["t3a.xlarge"]
min_size = 1
max_size = 4
desired_capacity = "4"
taints = "--register-with-taints=indico.io/minio=true:NoSchedule"
},
monitoring-workers = {
min_size = 1
Expand All @@ -129,31 +129,33 @@ locals {
taints = "--register-with-taints=indico.io/monitoring=true:NoSchedule"
},
weaviate = {
type = "cpu"
spot = false
instance_types = ["r5a.xlarge"]
min_size = 1
max_size = 3
desired_capacity = "3"
taints = "--register-with-taints=indico.io/weaviate=true:NoSchedule"
type = "cpu"
spot = false
instance_types = ["r5a.xlarge"]
min_size = 1
max_size = 3
desired_capacity = "3"
taints = "--register-with-taints=indico.io/weaviate=true:NoSchedule"
},
weaviate-workers = {
type = "cpu"
spot = false
instance_types = ["c6a.2xlarge"]
min_size = 1
max_size = 4
desired_capacity = "2"
taints = "--register-with-taints=indico.io/weaviate-workers=true:NoSchedule"
type = "cpu"
spot = false
instance_types = ["c6a.2xlarge"]
min_size = 1
max_size = 4
desired_capacity = "2"
taints = "--register-with-taints=indico.io/weaviate-workers=true:NoSchedule"
}
}

default_node_groups = merge((var.insights_enabled ? local.insights_default_node_groups : null), (var.ipa_enabled ? local.intake_default_node_groups : null))
default_node_groups = merge((var.insights_enabled ? local.insights_default_node_groups : tomap(null)), (var.ipa_enabled ? local.intake_default_node_groups : tomap(null)))

# This is to avoid terraform errors when the node groups variable is set,
# as different keys make the objects incompatible for a ternary function.
# To solve this, we set it to null which matches all types
default_node_groups_logic = var.node_groups == null ? local.default_node_groups : null
default_node_groups_logic = var.node_groups == null ? local.default_node_groups : tomap(null)

variable_node_groups = var.node_groups != null ? var.node_groups : tomap(null)

node_groups = var.node_groups == null ? local.default_node_groups_logic : var.node_groups
}
node_groups = merge(local.default_node_groups_logic, local.variable_node_groups)
}