Skip to content

Conversation

@HussainTechSavvy
Copy link
Contributor

@HussainTechSavvy HussainTechSavvy commented Nov 20, 2024

Changes Proposed

  • .dockerignore:

    • Added to exclude unnecessary files from the Docker image build process, reducing image size and improving build efficiency.
  • .editorconfig:

    • Added for consistent code formatting across the project.
  • GitHub Workflow:

    • Modified trigger rules for improved CI/CD efficiency.
    • Added a step to generate a temporary tag during the pull request process.
    • Added caching mechanisms, image labels, and annotations.
  • Dockerfile:

    • Enhanced to reduce the number of layers, improving performance and image size.
    • Fixed build-time warnings:
      • LegacyKeyValueFormat
      • InvalidDefaultArgInFrom
    • Upgraded Dockerize version from v0.6.1 to v0.8.0.
    • Upgraded s6-overlay version from 3.2.0.0 to 3.2.0.2.
    • Upgraded alpine version from 3.18 to 3.20.
  • s6-overlay:

    • Improved service initialization script for better reliability.

Check List

  • Code adheres to the project's style guidelines.
  • Documentation updates required for these changes.
  • Documentation has been updated accordingly.
  • All new and existing tests have passed.
  • No plagiarized content is included.
  • PR title provides a concise description of the changes.

Signed-off-by: HUSSAIN GANDHI <69318875+HussainTechSavvy@users.noreply.github.com>
Signed-off-by: HUSSAIN GANDHI <69318875+HussainTechSavvy@users.noreply.github.com>
Signed-off-by: HUSSAIN GANDHI <69318875+HussainTechSavvy@users.noreply.github.com>
Signed-off-by: HUSSAIN GANDHI <69318875+HussainTechSavvy@users.noreply.github.com>
Signed-off-by: HUSSAIN GANDHI <69318875+HussainTechSavvy@users.noreply.github.com>
Signed-off-by: HUSSAIN GANDHI <69318875+HussainTechSavvy@users.noreply.github.com>
@HussainTechSavvy HussainTechSavvy changed the title Update Dockerfile Refactor CI and Docker setup: Update GitHub Workflow, Dockerfile, s6-overlay script & add .editorconfig, and .dockerignore files Nov 20, 2024
@HussainTechSavvy HussainTechSavvy self-assigned this Nov 20, 2024
@HussainTechSavvy HussainTechSavvy added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 20, 2024
@HussainTechSavvy HussainTechSavvy changed the title Refactor CI and Docker setup: Update GitHub Workflow, Dockerfile, s6-overlay script & add .editorconfig, and .dockerignore files Updates to Workflow, Dockerfile, s6-Overlay, and Configuration Files Nov 20, 2024
aniketgohelimp
aniketgohelimp previously approved these changes Nov 20, 2024
@HussainTechSavvy HussainTechSavvy requested review from a team, Annavar-satish, Luv7804, disha2292 and lalitmoza and removed request for a team November 20, 2024 13:27
lalitmoza
lalitmoza previously approved these changes Nov 20, 2024
Annavar-satish
Annavar-satish previously approved these changes Nov 20, 2024
@HussainTechSavvy HussainTechSavvy merged commit 358ce0b into main Nov 21, 2024
7 checks passed
@HussainTechSavvy HussainTechSavvy deleted the dockerfile-bug branch November 21, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants