fix: Address runtime server selection for partial url#375
Open
igoroctaviano wants to merge 2 commits intomasterfrom
Open
fix: Address runtime server selection for partial url#375igoroctaviano wants to merge 2 commits intomasterfrom
igoroctaviano wants to merge 2 commits intomasterfrom
Conversation
|
|
|
Overall Grade Focus Area: Reliability |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Feb 26, 2026 7:19p.m. | Review ↗ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



SLIM / IDC-SLIM Improvements
Summary
Improvements to the server selector, authentication when switching servers, and worklist/slide list layout when DICOM attributes are missing.
Changes
Server selector: path-only URL support
https://healthcare.googleapis.com/v1/projects/.../dicomWeb)/projects/my-project/locations/us-central1/datasets/my-dataset/dicomStores/my-store/dicomWeb). The app automatically prependshttps://healthcare.googleapis.com/v1./projects/,/locations/,/datasets/, and/dicomStores/segments.Files:
slim/src/utils/url.tsx,idc-slim/src/utils/url.tsx,slim/src/components/Header.tsx,idc-slim/src/components/Header.tsx,slim/src/App.tsx,idc-slim/src/App.tsxServer selector: 401 fix when switching servers
Files:
slim/src/App.tsx,idc-slim/src/App.tsxServer selector: preview and display
baseURLso it reflects the URL used for fetches.Files:
slim/src/components/Header.tsx,idc-slim/src/components/Header.tsxREADME: runtime server selection
Files:
slim/README.mdWorklist: blank attributes and tiny rows
\u00A0) to keep row height consistent instead of collapsing.SeriesDescriptionis missing, the Description row shows an em dash (—) so slides without descriptions render at normal row size and remain clickable.Files:
slim/src/components/Worklist.tsx,idc-slim/src/components/Worklist.tsx,slim/src/components/SlideItem.tsx,idc-slim/src/components/SlideItem.tsxTesting
SeriesDescription; confirm slides show — and rows are not collapsed.