fix divide by zero from crafted file #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is the plan to skip the 1.2.0 release and go directly to 1.2.1, then? |
|
Thanks for the PR! I noticed the Issue is closed—should I follow up in the PR instead? I’d love to test the fix with my PoC and provide feedback. Let me know how you’d like to proceed! |
Collaborator
Author
|
Sorry for the silence, I've been trapped for weeks on another project :( I'm going to DICOM for the next week or two and catch up again. @bgilbert I think I'll aim for a formal 1.3 release with this fix plus the scrap of new API for catenation support. @xz0x if you could test this branch that'd be great, thanks! |
Collaborator
Author
|
Hmm, wait, now I reread the CHANGELOG let's do 1.2.0 instead as you suggested. I'll update this PR. |
jcupitt
force-pushed
the
fix-aithmetic-exception
branch
from
e77b3ac to
34d0614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #98