Volume dtype restriction#410
Open
mccle wants to merge 4 commits into
Open
Conversation
CPBridge
requested changes
May 28, 2026
Collaborator
CPBridge
left a comment
CPBridge
left a comment
There was a problem hiding this comment.
A couple of minor suggestions
Comment on lines
+2512
to
+2513
| "Argument 'array' must have a dtype of float, integer," | ||
| f" or bool, received '{array.dtype}'." |
Collaborator
There was a problem hiding this comment.
This suggests that the dtype must be one of these options exactly. How about:
Suggested change
| "Argument 'array' must have a dtype of float, integer," | |
| f" or bool, received '{array.dtype}'." | |
| "Argument 'array' must have an integer, floating point, " | |
| f" or boolean dtype, received '{array.dtype}'." |
Comment on lines
+1386
to
+1400
| for disallowed_dtype in [ | ||
| np.complex64, | ||
| complex, | ||
| np.complex128, | ||
| np.complex256, | ||
| str | ||
| ]: | ||
| with pytest.raises( | ||
| ValueError, | ||
| match=( | ||
| "Array must have a dtype of float, integer," | ||
| " or bool, received" | ||
| ) | ||
| ): | ||
| volume.array = np.zeros((10, 10, 10), dtype=disallowed_dtype) |
Collaborator
There was a problem hiding this comment.
What does this test? Isn't it the same regardless of dtype, and therefore run loads of times unnecessarily?
Would it be cleaner to have two tests: one for valid dtypes and the other for invalid dtypes?
Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks to the volume init and setter methods to ensure volumes have float, integer, or bool types. A new test was added to verify that volumes cannot be instantiated with an array of an unsupported data type nor changed after instantiation to a new data type that is unsupported.