Fix time-of-day-dependent failure in series_time validation#395
Merged
CPBridge merged 1 commit intoImagingDataCommons:masterfrom Feb 21, 2026
Merged
Conversation
The series_time > content_time check was performed regardless of whether series_date and content_date differed. When content_time defaults to now.time(), this caused spurious failures depending on what time of day the code (or tests) ran. The time comparison is now only performed when the dates are equal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
@yarikoptic thank you for the contribution! It looks good to me, but I would want @CPBridge to review, and he is out of office for several weeks. I am sure he will take a look as soon as he can! |
CPBridge
approved these changes
Feb 21, 2026
Collaborator
CPBridge
left a comment
CPBridge
left a comment
There was a problem hiding this comment.
Looks good, thanks @yarikoptic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The series_time > content_time check was performed regardless of whether series_date and content_date differed. When content_time defaults to now.time(), this caused spurious failures depending on what time of day the code (or tests) ran. The time comparison is now only performed when the dates are equal.
I just saw that CI is red -- troubleshooted/"solved" by claude-code