Open
Conversation
Member
fedorov
commented
Jan 23, 2026
fedorov
commented
- include SegmentationType
- make sure SegmentAlgorithmName is not REPEATED
- switch to using OHIF v3 for viewer_url
- use more concise initialSeriesInstanceUID for the viewer parameter
* include SegmentationType * make sure SegmentAlgorithmName is not REPEATED * switch to using OHIF v3 for viewer_url * use more concise initialSeriesInstanceUID for the viewer parameter
There was a problem hiding this comment.
Pull request overview
This PR updates the segmentations derived view to expose additional segmentation metadata and modernizes the viewer URL to use the OHIF v3 viewer with a simplified parameterization.
Changes:
- Adds
SegmentationTypeto the segmentation records by selecting it fromdicom_metadataand propagating it through thesegmentationsCTE. - Normalizes
SegmentAlgorithmNameselection by indexing the repeated field withSAFE_OFFSET(0)to avoid repeated-field issues. - Updates
viewer_urlto point to the OHIF v3 viewer, switching from the olderviewer/endpoint andseriesInstanceUIDlist toStudyInstanceUIDsplusinitialSeriesInstanceUIDusing the segmentation series UID.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fedorov
added a commit
to ImagingDataCommons/idc-index-data
that referenced
this pull request
Jan 23, 2026
Relies on a slightly modified version of the IDC segmentations table - this should be fixed once the query in this PR goes live: ImagingDataCommons/etl_flow#129
fedorov
added a commit
to ImagingDataCommons/idc-index-data
that referenced
this pull request
Jan 23, 2026
Relies on a slightly modified version of the IDC segmentations table - this should be fixed once the query in this PR goes live: ImagingDataCommons/etl_flow#129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.