-
Notifications
You must be signed in to change notification settings - Fork 9
Update to 1.21.4 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.21.4 #26
Conversation
No idea if this implementation would work with actual data, i dont know anything about how the new CustomModelData functions.
|
@ImCodist could this PR be accepted soon? |
|
Hey! Sorry for the wait! |
|
Honestly the changes to Custom Model Data here is making me consider removing the option entirely or replacing it with a better solution. Obviously one is easier then the other lol. I'd really prefer to keep it as a single number and I think there are ways to continue to work with that single integer value? I think I may start from scratch here and try to get it to work like it had previously and if I end up unsuccessful I'll merge your changes and consider what to do for the future. also please ignore the failing checks itts not your fault but instead a result of me failing to maintain this project LOL |
|
Custom icons doesn't sound too difficult to implement. I'd be willing to work with you on that. I haven't worked with the new implementation of CustomModelData so i have no clue how it works at all (and imma be honest, i dont want to look at it lol) |
|
Sure! That would be great! And honestly fair there's a reason I've been stalling for so long LOL. |
|
I mean implementation would just be an extra button in the item list with a browse dialog, copy the icon somewhere into a config folder, save that and display it Doesn't sound like too much work. Not too familiar with any of the rendering involved but owo takes care of that i think? |
|
Implemented my own method for CustomModelData and updated to 1.21.4. |
|
Thats fine, just be aware that not changing the name will break old configs, thats why i changed it in my PR |
For users: I've released the build with my current changes under my fork here. Use this at your own risk, backup your config just in case.
I've updated the mod to 1.21.4, i've given my best shot at it.
I've
Feel free to let me know about any changes you want done to my current approach.