Skip to content

Conversation

@TheXorog
Copy link

For users: I've released the build with my current changes under my fork here. Use this at your own risk, backup your config just in case.

I've updated the mod to 1.21.4, i've given my best shot at it.

I've

  • updated dependencies
  • Adjusted to use new CustomModelDataComponent
    • in the config, i use a self created type to give the properties of the component a proper name
    • i have honestly no idea how the new CustomModelDataComponent functions at all, this is my best guess
    • this will, when the user updates, delete their old custom model in their config until they update it themselves
    • the textbox for the custom data model ive changed to a textarea, to make it easier to input to

Feel free to let me know about any changes you want done to my current approach.

No idea if this implementation would work with actual data, i dont know anything about how the new CustomModelData functions.
@palette-dev
Copy link

@ImCodist could this PR be accepted soon?

@ImCodist
Copy link
Owner

ImCodist commented Feb 2, 2025

Hey! Sorry for the wait!
Lemme look through this now!

@ImCodist ImCodist self-assigned this Feb 2, 2025
@ImCodist ImCodist self-requested a review February 2, 2025 23:43
@ImCodist
Copy link
Owner

ImCodist commented Feb 3, 2025

Honestly the changes to Custom Model Data here is making me consider removing the option entirely or replacing it with a better solution. Obviously one is easier then the other lol.
In an ideal world I'd have it where players can just upload unique icon's to be displayed but ohhh godddd the work that I would need to do.

I'd really prefer to keep it as a single number and I think there are ways to continue to work with that single integer value?

I think I may start from scratch here and try to get it to work like it had previously and if I end up unsuccessful I'll merge your changes and consider what to do for the future.

also please ignore the failing checks itts not your fault but instead a result of me failing to maintain this project LOL

@TheXorog
Copy link
Author

TheXorog commented Feb 3, 2025

Custom icons doesn't sound too difficult to implement. I'd be willing to work with you on that.

I haven't worked with the new implementation of CustomModelData so i have no clue how it works at all (and imma be honest, i dont want to look at it lol)

@ImCodist
Copy link
Owner

ImCodist commented Feb 3, 2025

Sure! That would be great!

And honestly fair there's a reason I've been stalling for so long LOL.

@TheXorog
Copy link
Author

TheXorog commented Feb 3, 2025

I mean implementation would just be an extra button in the item list with a browse dialog, copy the icon somewhere into a config folder, save that and display it

Doesn't sound like too much work. Not too familiar with any of the rendering involved but owo takes care of that i think?

@ImCodist
Copy link
Owner

ImCodist commented Feb 3, 2025

Implemented my own method for CustomModelData and updated to 1.21.4.
https://github.com/ImCodist/quick-menu/releases/tag/v1.2.6

@ImCodist ImCodist closed this Feb 3, 2025
@TheXorog
Copy link
Author

TheXorog commented Feb 3, 2025

Thats fine, just be aware that not changing the name will break old configs, thats why i changed it in my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants