fix(pivot-grid): align IPivotAggregator aggregator type with PivotAggregation#17271
Open
Hristo313 wants to merge 1 commit into
Open
fix(pivot-grid): align IPivotAggregator aggregator type with PivotAggregation#17271Hristo313 wants to merge 1 commit into
Hristo313 wants to merge 1 commit into
Conversation
Hristo313
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a public typing inconsistency in the Pivot Grid API by aligning IPivotAggregator.aggregator with the existing PivotAggregation function type, resolving strict TypeScript assignment errors for custom aggregators (as reported in #15145) without changing runtime behavior.
Changes:
- Updated
IPivotAggregator.aggregatorto use thePivotAggregationtype alias (instead of an inline function type with an optionaldataparameter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15145
Description
Aligns the IPivotAggregator.aggregator type with PivotAggregation to fix an inconsistency in the public Pivot Grid typings. This resolves strict TypeScript errors when assigning custom aggregation functions in pivot value configurations. The change is type-only and does not affect runtime behavior.
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)