fix(simple-combo): Focus on programmatically closing combo #16806
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadzhov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical performance issue (issue #16664) where repeatedly clicking between multiple igx-simple-combo components caused CPU usage to increase and eventually freeze the browser. The root cause was a focus loop introduced in PR #12170, where the combo input was always refocused when the dropdown closed, even when the close was triggered by user interaction (like clicking on another combo).
Changes:
- Modified the
dropdown.closingevent handler to only callthis.comboInput.focus()when the combo is closed programmatically (when!args.event), preventing focus loops when users click between multiple combos - Added an explanatory comment documenting why focus is only applied for programmatic closes
Comment on lines
+234
to
+236
| // Only focus back when programmatically closing (no user event) | ||
| // to avoid focus loops when user clicks on another combo | ||
| this.comboInput.focus(); |
There was a problem hiding this comment.
The fix for the focus loop issue when alternating between multiple combos lacks test coverage. Consider adding a test that verifies:
- When a combo is closed programmatically (via the close() method), the input receives focus
- When a combo is closed due to user interaction (e.g., clicking outside or clicking another combo), the input does NOT receive focus
- Repeatedly clicking between two combos with selected items does not cause a focus loop
This would help prevent regressions of issue #16664.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16664
Only a programmatically closing combo should be focused. Initially it was like that but this PR forces
this.comboInput.focus();in both cases - when it's closed programmatically and due to user interaction:#12170