fix(grid): fix advanced filtering grid styles#3958
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the regression described in #3936 where the “advanced filtering custom styling” sample no longer shows custom styles (staging shows defaults), by reintroducing custom theming overrides for the Advanced Filtering dialog UI.
Changes:
- Replaces the previous
query-builder-theme(...)token approach with a set of dark-material-based theme definitions for buttons, button groups, input groups, chips, and dropdowns. - Applies these theme overrides to
igx-advanced-filtering-dialogvia@include theme(...)and@include css-vars(...). - Adds a border override for contained buttons (and an additional selector targeting an Excel-filter clear button).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the old custom styles for the advanced filtering
Closes #3936